Ng/hci cut - #78
Merged
Merged
Conversation
FrancescoConti
requested changes
May 19, 2026
FrancescoConti
left a comment
Member
There was a problem hiding this comment.
Only a minor change to the header in hci_core_cut.sv is required before merging.
| @@ -0,0 +1,126 @@ | |||
| // Copyright 2023 ETH Zurich and University of Bologna. | |||
Member
There was a problem hiding this comment.
Use the style from other HCI files, and add Fondazione Chips-IT as copyright holder.
So something like
/*
* hci_core_cut.sv
* Niccolò Giuliani <niccolo.giuliani@chips.it>
*
* Copyright (C) 2026 ETH Zurich, University of Bologna and Fondazione Chips-IT
* Copyright and related rights are licensed under the Solderpad Hardware
* License, Version 0.51 (the "License"); you may not use this file except in
* compliance with the License. You may obtain a copy of the License at
* http://solderpad.org/licenses/SHL-0.51. Unless required by applicable law
* or agreed to in writing, software, hardware and materials distributed under
* this License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
* CONDITIONS OF ANY KIND, either express or implied. See the License for the
* specific language governing permissions and limitations under the License.
*/
/**
* The **hci_core_cut** module implements a simple assignment for
* HCI-Core streams.
*
*/
FrancescoConti
approved these changes
May 20, 2026
Member
|
seems fine now, but for some reason it fails the non-regression test. i will give a look |
Member
|
should be fixed, it was a size mismatch with the testbench. i will merge if it passes nonreg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding of hci cuts for idma,ext and cores:
The parameters CUT_CORES, CUT_IDMA and CUT_EXT set to 1 permits to add cuts in the rtl/ecc/hci_ecc_interconnect.sv and rtl/hci_interconnect.sv .