Fix optional dependency marker parsing#109
Open
EmilStenstrom wants to merge 1 commit into
Open
Conversation
EmilStenstrom
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix dependency classification on package pages by parsing each
Requires-Distentry withpackaging.requirements.Requirementinstead of looking for the literal substring; extra ==.The old check missed valid markers such as:
That caused optional dependencies to appear under Required dependencies, as seen on the justhtml package page and in the same class of issue as #79.
Validation
PYENV_VERSION=3.13.13 python -m py_compile pypistats/*.py pypistats/**/*.py/tmp/pypistats-venv/bin/black --check ./tmp/pypistats-venv/bin/isort --check-only .mypyis optional for the justhtml-style marker while non-extra requirements remain required