-
Notifications
You must be signed in to change notification settings - Fork 96
Add zizmor security linter #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
7280229
5780a74
4557628
ac8c66d
bee0961
0135f77
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| name: Lint | ||
|
|
||
| on: [push, pull_request, workflow_dispatch] | ||
|
|
||
| permissions: {} | ||
|
|
||
| env: | ||
| FORCE_COLOR: 1 | ||
|
|
||
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0 | ||
| with: | ||
| python-version: "3.x" | ||
| - uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0 | ||
| - uses: j178/prek-action@cbc2f23eb5539cf20d82d1aabd0d0ecbcc56f4e3 # v2.0.2 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| build |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # | ||
| # This file is autogenerated by pip-compile with Python 3.14 | ||
| # by the following command: | ||
| # | ||
| # pip-compile --generate-hashes --output-file=/private/tmp/pyperf/.github/workflows/publish.txt /private/tmp/pyperf/.github/workflows/publish.in | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When and how is one supposed to update this file? Should it be updated when preparing a release? Is it regenerated by Dependabot? Maybe add instructions to pyproject.toml header (the long comment)?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Yes, this PR adds the And then we get Dependabot PRs like python/release-tools#364. It'll open a PR once a month if needed. The 7 day cooldown means it won't consider an update within that time, which also gives supply-chain attack protection. However, the schedule+cooldown don't apply to security updates -- Dependabot will open PRs for those sooner.
No need, it can be updated during by Dependabot as and when needed.
Yep, will do.
hugovk marked this conversation as resolved.
Outdated
|
||
| # | ||
| build==1.4.4 \ | ||
| --hash=sha256:8c3f48a6090b39edec1a273d2d57949aaf13723b01e02f9d518396887519f64d \ | ||
| --hash=sha256:f832ae053061f3fb524af812dc94b8b84bac6880cd587630e3b5d91a6a9c1703 | ||
| # via -r /private/tmp/pyperf/.github/workflows/publish.in | ||
| packaging==26.1 \ | ||
| --hash=sha256:5d9c0669c6285e491e0ced2eee587eaf67b670d94a19e94e3984a481aba6802f \ | ||
| --hash=sha256:f042152b681c4bfac5cae2742a55e103d27ab2ec0f3d88037136b6bfe7c9c5de | ||
| # via build | ||
| pyproject-hooks==1.2.0 \ | ||
| --hash=sha256:1e859bd5c40fae9448642dd871adf459e5e2084186e8d2c2a79a824c970da1f8 \ | ||
| --hash=sha256:9e5c6bfa8dcc30091c74b0cf803c81fdd29d94f01992a7707bc97babb1141913 | ||
| # via build | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| repos: | ||
| - repo: https://github.com/pre-commit/pre-commit-hooks | ||
| rev: v6.0.0 | ||
| hooks: | ||
| - id: check-added-large-files | ||
| - id: check-case-conflict | ||
| - id: check-merge-conflict | ||
| - id: check-json | ||
| - id: check-toml | ||
| - id: check-yaml | ||
| - id: debug-statements | ||
| - id: end-of-file-fixer | ||
| - id: forbid-submodules | ||
| - id: trailing-whitespace | ||
|
|
||
| - repo: https://github.com/python-jsonschema/check-jsonschema | ||
| rev: 0.37.1 | ||
| hooks: | ||
| - id: check-dependabot | ||
| - id: check-github-workflows | ||
|
|
||
| - repo: https://github.com/rhysd/actionlint | ||
| rev: v1.7.12 | ||
| hooks: | ||
| - id: actionlint | ||
|
|
||
| - repo: https://github.com/zizmorcore/zizmor-pre-commit | ||
| rev: v1.24.1 | ||
| hooks: | ||
| - id: zizmor | ||
|
|
||
| - repo: https://github.com/abravalheri/validate-pyproject | ||
| rev: v0.25 | ||
| hooks: | ||
| - id: validate-pyproject | ||
|
|
||
| - repo: meta | ||
| hooks: | ||
| - id: check-hooks-apply | ||
| - id: check-useless-excludes |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,4 +8,3 @@ Perf Developer Guide | |
| examples | ||
| api | ||
| changelog | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -122,4 +122,3 @@ Usage:: | |
|
|
||
| $ python3 plot.py telco.json telco.csv | ||
| $ python3 plot.py result.json -b telco telco.csv | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,5 +11,3 @@ Table of Contents: | |
| cli | ||
| runner | ||
| system | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hugovk
What do you think about pinning it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary for the linter. GitHub likely won't bump it to 3.15 until some time after its final release, so everything should be ready by then.
But not a strong opinion against pinning.