Remove Unsafe usage from CodedOutputStream.#27347
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_914326306
branch
from
7760c65 to
ba0cef8
Compare
This change effectively has the runtime behavior of hardcoding HAS_UNSAFE_ARRAY_OPERATIONS to false, which was measured as a net performance improvement after the recent loop unrolling changes. This is one of the last steps towards no longer using the terminally deprecated sun.misc.Unsafe from JavaFull. PiperOrigin-RevId: 914398839
copybara-service
Bot
force-pushed
the
test_914326306
branch
from
ba0cef8 to
fddc1b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Unsafe usage from CodedOutputStream.
This change effectively has the runtime behavior of hardcoding HAS_UNSAFE_ARRAY_OPERATIONS to false, which was measured as a net performance improvement after the recent loop unrolling changes.
This is one of the last steps towards no longer using the terminally deprecated sun.misc.Unsafe from JavaFull.