Skip to content

fix: pin OpenCode CLI version in Kubeflow Dockerfile #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
geier wants to merge 2 commits into from
Closed

fix: pin OpenCode CLI version in Kubeflow Dockerfile #225

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcd5b96
fix: pin OpenCode CLI version in Kubeflow Dockerfile
geier Apr 11, 2026
b46835a
review: improve version pinning comment to mention CI build-arg
geier Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/pk-opencode.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ jobs:
-t $LATEST_TAG \
-f docker/kubeflow/Dockerfile \
--platform linux/amd64 \
--build-arg OPENCODE_VERSION=1.2.6 \

Copilot AI Apr 11, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPENCODE_VERSION is now hardcoded here as well as in docker/kubeflow/Dockerfile (ARG default). This duplication can drift and reintroduce the “silent version change” problem during upgrades. Consider defining OPENCODE_VERSION once (e.g., as a workflow-level env var) and referencing it from the build command, and ensure the Dockerfile default is kept in sync for local builds.

Copilot uses AI. Check for mistakes.

@geier geier Apr 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledged. This duplication pattern is consistent with how S6_OVERLAY_VERSION is handled in the same workflow and Dockerfile — it's a deliberate choice that keeps local builds working (using the ARG default) while CI can override. The comment fix in the latest commit now explicitly warns that both values must be kept in sync, which mitigates the drift risk.

--build-arg S6_OVERLAY_VERSION=3.1.6.2 \
--build-arg KF_EXAMPLES_REPO=https://github.com/prokube-ai/kubeflow-examples.git \
--label "org.opencontainers.image.title=OpenCode Prefixable UI" \
Expand Down
5 changes: 4 additions & 1 deletion docker/kubeflow/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,11 @@ RUN curl -fsSL https://bun.sh/install | bash -s "bun-v${BUN_VERSION}" && \
rm -rf /root/.bun

# Install OpenCode CLI
# Pin version to ensure reproducible builds. Update by changing OPENCODE_VERSION.

Copilot AI Apr 11, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upgrade note here is potentially misleading because CI overrides the Dockerfile default via --build-arg OPENCODE_VERSION=... in .github/workflows/pk-opencode.yml. To avoid someone updating only this ARG and still getting the old version in CI, please either (a) mention that the workflow build-arg must be updated too, or (b) centralize the version in one place (e.g., workflow env var) so the Dockerfile comment stays accurate.

Suggested change
# Pin version to ensure reproducible builds. Update by changing OPENCODE_VERSION.
# Pin version to ensure reproducible builds.
# NOTE: CI overrides this default with `--build-arg OPENCODE_VERSION=...` in
# `.github/workflows/pk-opencode.yml`, so upgrades must keep both values in sync.

Copilot uses AI. Check for mistakes.
# Check releases at: https://github.com/anomalyco/opencode/releases
ARG OPENCODE_VERSION=1.2.6
ENV SHELL=/bin/bash
RUN curl -fsSL https://opencode.ai/install | bash && \
RUN curl -fsSL https://opencode.ai/install | bash -s -- --version "${OPENCODE_VERSION}" && \
mv /root/.opencode/bin/opencode /usr/local/bin/opencode && \
rm -rf /root/.opencode

Expand Down