Compressing .zap file with better readability#29019
Closed
brdandu wants to merge 1 commit into
Closed
Conversation
…m to smaller size. Also making sure that they are more readable and easy to hand edit JIRA: ZAPP-1113
andy31415
reviewed
Sep 5, 2023
| "outgoing": 0 | ||
| } | ||
| " code | mfgCode | source | incoming | outgoing", | ||
| "0x0001 | | server | 1 | 1 => ArmFailSafeResponse", |
Contributor
There was a problem hiding this comment.
While this is readable, this has other issues:
- not script-editable really anymore
- unclear meaning: why do we have an empty mfgCode in there, why do we have a "source" if it is always the same for matter products, what does incoming mean (why is there a 0 for regulatory config when all responses are the same), what does "1 =>" mean ...
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Contributor
|
PR with merge conflicts and in draft form after a long time. assuming stale and closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching .zap files to have only enabled content and compressing them to smaller size. Also making sure that they are more readable and easy to hand edit
JIRA: ZAPP-1113
Associated ZAP PR: project-chip/zap#1121