Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Update Javascript dependencies#2166

Merged
dngray merged 2 commits into
privacytools:masterfrom
Gusted:jqeury-fix
Dec 29, 2020
Merged

Update Javascript dependencies#2166
dngray merged 2 commits into
privacytools:masterfrom
Gusted:jqeury-fix

Conversation

@Gusted

@Gusted Gusted commented Dec 25, 2020

Copy link
Copy Markdown
Contributor

Description

Resolves: #2165

As in issue #2165 the current version of Bootstrap still relies on jQuery, since v5 bootstrap only relies on the already existence popper.js(@popper/core) dependency.
Thereby updating those 2 dependencies fixes this issue and still maintain all features.
Eventually the non beta of Bootstrap v5 can be used when it's stable.

Summary of what this PR means:

  • Update bootstrap to v5.0.0-beta1.
  • Update popper.js to v2.6.0.
  • Update Javascript license of popper.js.
  • Bump version in scripts.html.

Check List

  • I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging.

  • I have read and understand the contributing guidelines.

  • The project is Free Libre and/or Open Source Software

Gusted added 2 commits December 25, 2020 16:09
- Update Bootstrap to v5.0.0-beta1.
- Update popper.js to v2.6.0.
- Update Javascript license of popper.js.
- Bump version in `scripts.html`.
@Gusted Gusted requested a review from a team as a code owner December 25, 2020 15:20
@dngray dngray self-requested a review December 25, 2020 15:27
@dngray

dngray commented Dec 25, 2020

Copy link
Copy Markdown
Collaborator

Thanks a lot for this, I'll check it out soon!

@dngray

dngray commented Dec 26, 2020

Copy link
Copy Markdown
Collaborator

Looks good.

Only errors i was seeing was:

/usr/lib/ruby/gems/2.7.0/gems/jekyll-3.8.5/lib/jekyll/convertible.rb:41: warning: Using the last argument as keyword parameters is deprecated
/usr/lib/ruby/gems/2.7.0/gems/jekyll-3.8.5/lib/jekyll/tags/include.rb:194: warning: Using the last argument as keyword parameters is deprecated
/usr/lib/ruby/gems/2.7.0/gems/pathutil-0.16.2/lib/pathutil.rb:502: warning: Using the last argument as keyword parameters is deprecated
/usr/lib/ruby/gems/2.7.0/gems/rb-inotify-0.10.0/lib/rb-inotify/watcher.rb:66: warning: rb_safe_level will be removed in Ruby 3.0

I wonder if there's anything we can do about these.

@Gusted

Gusted commented Dec 26, 2020

Copy link
Copy Markdown
Contributor Author

Looks good.

Only errors i was seeing was:

/usr/lib/ruby/gems/2.7.0/gems/jekyll-3.8.5/lib/jekyll/convertible.rb:41: warning: Using the last argument as keyword parameters is deprecated
/usr/lib/ruby/gems/2.7.0/gems/jekyll-3.8.5/lib/jekyll/tags/include.rb:194: warning: Using the last argument as keyword parameters is deprecated
/usr/lib/ruby/gems/2.7.0/gems/pathutil-0.16.2/lib/pathutil.rb:502: warning: Using the last argument as keyword parameters is deprecated
/usr/lib/ruby/gems/2.7.0/gems/rb-inotify-0.10.0/lib/rb-inotify/watcher.rb:66: warning: rb_safe_level will be removed in Ruby 3.0

I wonder if there's anything we can do about these.

Those are ruby dependencies. A small sudo bundle update should update most dependencies to 2.7+ ruby language. The only warning after updating is

/var/lib/gems/2.7.0/gems/pathutil-0.16.2/lib/pathutil.rb:502: warning: Using the last argument as keyword parameters is deprecated

Which seems to me that some dependency is still using an old version of pathutil, but that's an issue for another pr/issue.

@Gusted

Gusted commented Dec 26, 2020

Copy link
Copy Markdown
Contributor Author

Which seems to me that some dependency is still using an old version of pathutil, but that's an issue for another pr/issue.

https://github.com/envygeeks/pathutil the last update was from 2018 and is 0.16.2 which is currently specified in gemfile.lock. pathutil is utilized by jekyll.

Their is an open issue about it envygeeks/pathutil#4 and an open PR envygeeks/pathutil#5, however their seems to be no progress.

@Gusted Gusted mentioned this pull request Dec 26, 2020
3 tasks
@dngray dngray merged commit 1fab03f into privacytools:master Dec 29, 2020
@Gusted Gusted deleted the jqeury-fix branch December 29, 2020 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🌐 Website Issue | Error in console

2 participants