Skip to content

Skip user activity tracking in local dev #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elemdos merged 1 commit into from
Jun 25, 2026
Merged

Skip user activity tracking in local dev #1181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/lib/UserActivity.svelte.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { build_cms_page_url } from './pages'
import { site_context } from './builder/stores/context'
import { get } from 'svelte/store'
import { current_user } from './pocketbase/user'
import { instance } from './instance'
import type { ObjectOf } from './pocketbase/CollectionMapping.svelte'

export type UserActivityValues = Omit<UserActivity, 'id'>
Expand All @@ -29,6 +30,11 @@ export type UserActivityInfo = {
const user_activity_context = new Context<{ value: UserActivityValues }>('user_activity')

export const setUserActivity = (overrides: Partial<UserActivityValues>) => {
// User activity is collaborator presence ("who else is editing this site").
// It's meaningless in local dev (single user, no collaborators) and would
// write churn records against the local DB, so don't track it there.
if (instance.dev_mode) return

const existing_context = user_activity_context.getOr({ value: null })
if (existing_context.value) {
// Set activity overrides through context
Expand Down Expand Up @@ -138,7 +144,11 @@ export const setUserActivity = (overrides: Partial<UserActivityValues>) => {
onDestroy(stopTracking)
}

export const getUserActivity = ({ filter }: { filter?: (activity: UserActivityInfo) => unknown } = {}) => {
export const getUserActivity = ({ filter }: { filter?: (activity: UserActivityInfo) => unknown } = {}): UserActivityInfo[][] => {
// No collaborator presence in local dev — skip the list (which would also
// try to resolve activities pointing at since-deleted pages and throw).
if (instance.dev_mode) return []

const { value: site } = site_context.get()
return (UserActivities.list({ filter: { site: site.id } }) ?? [])
.filter((activity) => activity.user !== get(current_user)?.id)
Expand Down