Skip to content

fix : expert icon rendering with fallback to default icon #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anand-presidio merged 2 commits into from
Apr 28, 2025
Merged

fix : expert icon rendering with fallback to default icon #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7358953
fix: expert icon rendering with fallback to default person icon
Mage1507 Apr 28, 2025
fd31027
doc: added changeset
Mage1507 Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/happy-seals-roll.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"hai-build-code-generator": patch
---

Fix expert icon rendering to properly display image or fallback to a default icon.
9 changes: 7 additions & 2 deletions webview-ui/src/components/chat/ChatTextArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1297,10 +1297,15 @@ const ChatTextArea = forwardRef<HTMLTextAreaElement, ChatTextAreaProps>(
onClick={handleExpertsButtonClick}
tabIndex={0}>
<ExpertsButtonContent>
{selectedExpert && selectedExpert.iconComponent && (
{selectedExpert && selectedExpert.iconComponent ? (
<div style={{ width: "12px", height: "12px", display: "flex", alignItems: "center" }}>
<selectedExpert.iconComponent />
<img src={selectedExpert.iconComponent} alt={`${selectedExpert.name} icon`} />
</div>
) : (
<span
className="codicon codicon-person"
style={{ fontSize: "12px", width: "12px", height: "12px" }}
/>
)}
{selectedExpert ? selectedExpert.name : "Default"}
</ExpertsButtonContent>
Expand Down
Loading