Add configuration hierarchy for automated workflows#759
Draft
danimcgoo wants to merge 4 commits into
Draft
Conversation
…pecs Conducted full design review of worktree permission config and zone model config specifications. Key findings: Critical Issues: - No unified configuration hierarchy between worktree defaults and zone triggers - Missing product reasoning for features - Security concerns with worktree-level permission defaults Recommendation: REVISE both specs with unified hierarchy, product justification, and enhanced security model. Consider phased rollout (zone model config first). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace three separate specs with one clear design document covering: - Product reasoning: Assistant workflows with zone-based model selection - Unified configuration hierarchy for automated vs manual session creation - Zone trigger model config (for automated workflows) - Worktree default config (for user sessions) - Security model, UI design, implementation plan Addresses all design review findings with focus on purpose and outcome. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Removed worktree permission defaults feature - out of scope for this PR. Changes: - Focus exclusively on zone trigger model config (the actual use case) - Remove security model section (not applicable - model config only) - Update UI design to reuse existing ModelSelector component - Simplify configuration hierarchy (zone → recent session → user → SDK) - Remove worktree-related items from implementation checklist Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
More descriptive filename that clearly indicates the feature scope. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
@mistercrunch, also curious for your feedback on this one. Seeking to optimise compute by allowing zones to use specific models. A key question: Should zone triggers apply to session reuse, as well as auto new session? Currently I've said no - but am unsure - as there's a good argument for it to apply to both. Probably better UX. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables Agor Assistants to create multi-stage workflows where different zones use different models (Opus for research, Sonnet for implementation).
Two complementary features:
Zone Trigger Model Config: Zone-specific model selection for automated sessions
Worktree Default Config: Worktree-level defaults for user-created sessions
Unified configuration hierarchy clearly defines precedence for automated vs manual session creation.
Changes
specs/DESIGN.mdTest Plan
🤖 Generated with Claude Code