Dotnet buildaction uses given build action verbatim if no matching mapping is found rather than using the None fallback#2729
Open
CapeGuyBen wants to merge 1 commit into
Conversation
Contributor
Author
|
Improves #614. Though there's a possibility of a name clash between premake's predefined actions and the user's custom name with this approach. This allows custom build actions (defined via project dependencies) to be run but does not allow the user to specify new ones. |
Jarod42
reviewed
Jul 8, 2026
Jarod42
left a comment
Jarod42
left a comment
Contributor
There was a problem hiding this comment.
Would i make sense to extend it to C/C++ actions too?
| end | ||
| else | ||
| info.action = "None" | ||
| if (fcfg.buildaction == nul) then |
Contributor
There was a problem hiding this comment.
Suggested change
| if (fcfg.buildaction == nul) then | |
| if fcfg.buildaction == nil then |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if this makes sense for C++ projects in general. Is the concept applicable to all the generators? It's probably a bit beyond the scope of this PR.
…pping is found rather than using the None fallback
CapeGuyBen
force-pushed
the
feature/dotnet_build_action_fallback
branch
from
ad3be42 to
6460202
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows user-specific build actions to be specified by using the given build action verbatim if no mapping is found rather than falling back to "None".
How does this PR change Premake's behavior?
If a build action is provided that doesn't match one of the pre-defined actions then it will be applied to the associated files as specified instead of being ignored.
For example, MonoGame projects use the custom "MonoGameContentReference" buildaction. With this change it's possible to specify that when using a premake project.
closes #XXXXin comment to auto-close issue when PR is merged)