Skip to content

Support cross-installing of prebuilt packages via npm_config_* vars #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pimterry wants to merge 2 commits into
base: master
Choose a base branch
from
+15 −6
Open

Support cross-installing of prebuilt packages via npm_config_* vars #50

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3dc6a9
Support cross-installing of prebuilt packages via npm_config_* vars
pimterry Aug 5, 2022
2c1cccf
Apply suggestions from code review
pimterry Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions bin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,22 @@ var proc = require('child_process')
var os = require('os')
var path = require('path')

var targetMismatch = (process.env.npm_config_platform && process.platform !== process.env.npm_config_platform) ||
Comment thread
vweevers marked this conversation as resolved.
(process.env.npm_config_arch && process.arch !== process.env.npm_config_arch)
Comment thread
vweevers marked this conversation as resolved.

if (!buildFromSource()) {
proc.exec('node-gyp-build-test', function (err, stdout, stderr) {
if (err) {
if (verbose()) console.error(stderr)
preinstall()
}
})
if (targetMismatch) {
// If the target is mismatched, then we can't test built output, and we can't build from source either.
Comment thread
pimterry marked this conversation as resolved.
Outdated
// Instead, we just check whether a matching prebuild exists, and fail if it doesn't.
require('./index').path(process.cwd())
Comment thread
pimterry marked this conversation as resolved.
Outdated
} else {
proc.exec('node-gyp-build-test', function (err, stdout, stderr) {
Comment thread
vweevers marked this conversation as resolved.
if (err) {
if (verbose()) console.error(stderr)
preinstall()
}
})
}
} else {
preinstall()
}
Expand Down