refactor: Inline SVG defs#1358
Open
rschristian wants to merge 1 commit into
Open
Conversation
|
Size Change: -1 B (0%) Total Size: 449 kB ℹ️ View Unchanged
|
rschristian
commented
Nov 13, 2025
| <link href="https://www.google-analytics.com" rel="preconnect" crossorigin="anonymous"> | ||
| </head> | ||
| <body class="banner"> | ||
| <svg xmlns="http://www.w3.org/2000/svg" style="display: none;"> |
Member
Author
There was a problem hiding this comment.
Alternatively could keep this separate & just write a Vite plugin to inline it into the HTML, dunno if that's better or worse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/assets/icons.svgmakes up the header icons & the "link" icon used on heading elements throughout our doc pages. Inlining it adds ~1.6kb to the HTML (9.49kb -> 11.09kb, in the preview env) but these are always going to be within the initial viewport of every page so it probably makes sense to do. Trading cachability for faster rendering.There's no way to do preloading of SVG sprite sheets yet (https://issues.chromium.org/issues/40681653 & whatwg/fetch#1012 are long-standing issues) so this is the next best option.