Skip to content

Fix generator targetP update in AC-DC networks #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SylvestreSakti merged 4 commits into from
Mar 23, 2026
Merged

Fix generator targetP update in AC-DC networks #1373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef2f9cc
Fix generator setTargetP behaviour in slack mismatch
bperr Mar 18, 2026
80c97a9
Add comments in LfAcDcNetwork.java
bperr Mar 19, 2026
d514ec1
Merge branch 'main' into fix-slack-ac-dc
SylvestreSakti Mar 23, 2026
f755592
Merge branch 'main' into fix-slack-ac-dc
SylvestreSakti Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/main/java/com/powsybl/openloadflow/network/LfAcDcNetwork.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ public LfAcDcNetwork(List<LfNetwork> acNetworks, List<LfNetwork> dcNetworks) {
this.acNetworks = List.copyOf(acNetworks);
this.dcNetworks = List.copyOf(dcNetworks);

// Add LfElements in the LfAcDcNetwork. Their number is therefore updated to match the global LfAcDcNetwork object.
// However their getNetwork() method still returns the original LfNetwork they belong to.
// Having all elements in the LfAcDcNetwork allows to simulate load flow the whole connected network
// The attributes acNetworks and dcNetworks also allow to access a "child" etwork individually.
for (LfNetwork network : acNetworks) {
network.getBuses().forEach(this::addBus);
network.getBranches().forEach(this::addBranch);
Expand All @@ -40,7 +44,20 @@ public LfAcDcNetwork(List<LfNetwork> acNetworks, List<LfNetwork> dcNetworks) {
network.getDcBuses().forEach(this::addDcBus);
network.getDcLines().forEach(this::addDcLine);
}
}

@Override
public void addListener(LfNetworkListener listener) {
// LfElements getNetwork() method returns the original LfNetwork they belong to.
// Therefore, any listener attached to the LfAcDcNetwork should be attached to the "children" LfNetworks in order
// to be triggered when accessing the original LfNetwork listeners through an LfElement via the method getNetwork()
super.addListener(listener);
for (LfNetwork acNetwork : acNetworks) {
acNetwork.addListener(listener);
}
for (LfNetwork dcNetwork : dcNetworks) {
dcNetwork.addListener(listener);
}
}

@Override
Expand Down
71 changes: 57 additions & 14 deletions src/test/java/com/powsybl/openloadflow/acdc/AcDcLoadFlowTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ void testVscAsymmetricalMonopole() {

Bus busGb150 = network.getBusBreakerView().getBus("BUSDC-GB-xNodeDc1gb-150");
assertVoltageEquals(150.043375, busGb150);
assertAngleEquals(2.976066, busGb150);
assertAngleEquals(2.977430, busGb150);

Bus busFr400 = network.getBusBreakerView().getBus("BUSDC-FR-xNodeDc1fr-400");
assertVoltageEquals(399.551518, busFr400);
Expand All @@ -239,7 +239,7 @@ void testVscAsymmetricalMonopole() {

Bus busGb = network.getBusBreakerView().getBus("BUS-GB");
assertVoltageEquals(400.000000, busGb);
assertAngleEquals(-0.00061, busGb);
assertAngleEquals(0.000754, busGb);

DcNode dcNodeGbNeg = network.getDcNode("dcNodeGbNeg");
assertVoltageEquals(0.000000, dcNodeGbNeg);
Expand All @@ -255,7 +255,7 @@ void testVscAsymmetricalMonopole() {

Generator genFr = network.getGenerator("GEN-FR");
assertActivePowerEquals(-2000.732810, genFr.getTerminal());
assertReactivePowerEquals(-10.470861, genFr.getTerminal());
assertReactivePowerEquals(-10.617409, genFr.getTerminal());

VoltageSourceConverter vscFr = network.getVoltageSourceConverter("VscFr");
assertActivePowerEquals(200.806464, vscFr.getTerminal1());
Expand All @@ -274,10 +274,10 @@ void testVscAsymmetricalMonopole() {
assertDcPowerEquals(-200.000000, dcLinePos.getDcTerminal2());

Line acLine = network.getLine("acLine");
assertActivePowerEquals(0.327588, acLine.getTerminal1());
assertActivePowerEquals(-0.327588, acLine.getTerminal2());
assertReactivePowerEquals(-0.065519, acLine.getTerminal1());
assertReactivePowerEquals(0.065519, acLine.getTerminal2());
assertActivePowerEquals(-0.405145, acLine.getTerminal1());
assertActivePowerEquals(0.405145, acLine.getTerminal2());
assertReactivePowerEquals(0.081032, acLine.getTerminal1());
assertReactivePowerEquals(-0.081032, acLine.getTerminal2());
}

@Test
Expand Down Expand Up @@ -312,7 +312,7 @@ void testVscSymmetricalMonopole() {

Bus busGb150 = network.getBusBreakerView().getBus("BUSDC-GB-xNodeDc1gb-150");
assertVoltageEquals(150.043375, busGb150);
assertAngleEquals(2.976065, busGb150);
assertAngleEquals(2.978183, busGb150);

Bus busFr400 = network.getBusBreakerView().getBus("BUSDC-FR-xNodeDc1fr-400");
assertVoltageEquals(399.557158, busFr400);
Expand All @@ -329,8 +329,8 @@ void testVscSymmetricalMonopole() {
assertVoltageEquals(-250.000000, dcNodeFrPos);

Generator genGb = network.getGenerator("GEN-GB");
assertActivePowerEquals(-2001.713011, genGb.getTerminal());
assertReactivePowerEquals(-10.448402, genGb.getTerminal());
assertActivePowerEquals(-2001.137135, genGb.getTerminal());
assertReactivePowerEquals(-10.220984, genGb.getTerminal());

VoltageSourceConverter vscFr = network.getVoltageSourceConverter("VscFr");
assertActivePowerEquals(201.626136, vscFr.getTerminal1());
Expand Down Expand Up @@ -359,10 +359,10 @@ void testVscSymmetricalMonopole() {
assertDcPowerEquals(0.000013, dlGroundPos.getDcTerminal1());

Line acLine = network.getLine("acLine");
assertActivePowerEquals(0.327588, acLine.getTerminal1());
assertActivePowerEquals(-0.327588, acLine.getTerminal2());
assertReactivePowerEquals(-0.065519, acLine.getTerminal1());
assertReactivePowerEquals(0.065519, acLine.getTerminal2());
assertActivePowerEquals(-0.809547, acLine.getTerminal1());
assertActivePowerEquals(0.809547, acLine.getTerminal2());
assertReactivePowerEquals(0.161920, acLine.getTerminal1());
assertReactivePowerEquals(-0.161920, acLine.getTerminal2());
}

@Test
Expand Down Expand Up @@ -410,6 +410,49 @@ void testAcDcExample() {
assertDcPowerEquals(-49.359850, dl34.getDcTerminal2());
}

@Test
void testAcDcExampleOtherSlack() {
// 2 converters, 1 AC Network, the first converter controls Pac, and the second one Vdc
// The slack bus is located to another AC bus
network = AcDcNetworkFactory.createAcDcNetwork1();
parametersExt.setSlackBusSelectionMode(SlackBusSelectionMode.NAME)
.setSlackBusId("vl2_0");
LoadFlowResult result = loadFlowRunner.run(network, parameters);
assertTrue(result.isFullyConverged());

DcNode dn3 = network.getDcNode("dn3");
assertVoltageEquals(400.012374, dn3);

DcNode dn4 = network.getDcNode("dn4");
assertVoltageEquals(400.000000, dn4);

Generator g1 = network.getGenerator("g1");
assertActivePowerEquals(-101.35133, g1.getTerminal());
assertReactivePowerEquals(-20.212180, g1.getTerminal());

VoltageSourceConverter conv23 = network.getVoltageSourceConverter("conv23");
assertActivePowerEquals(50.000000, conv23.getTerminal1());
assertReactivePowerEquals(0.000000, conv23.getTerminal1());
assertDcPowerEquals(-49.361373, conv23.getDcTerminal1());
assertDcPowerEquals(0.000000, conv23.getDcTerminal2());

VoltageSourceConverter conv45 = network.getVoltageSourceConverter("conv45");
assertActivePowerEquals(-48.721223, conv45.getTerminal1());
assertReactivePowerEquals(0.000000, conv45.getTerminal1());
assertDcPowerEquals(49.359850, conv45.getDcTerminal1());
assertDcPowerEquals(0.000000, conv45.getDcTerminal2());

Line l12 = network.getLine("l12");
assertActivePowerEquals(101.35133, l12.getTerminal1());
assertReactivePowerEquals(20.212180, l12.getTerminal1());
assertActivePowerEquals(-101.28111, l12.getTerminal2());
assertReactivePowerEquals(-20.002003, l12.getTerminal2());

DcLine dl34 = network.getDcLine("dl34");
assertDcPowerEquals(49.361372, dl34.getDcTerminal1());
assertDcPowerEquals(-49.359850, dl34.getDcTerminal2());
}

@Test
void testAcDcExampleWithOtherControl() {
//2 converters, 1 AC Network, the first converter controls Vdc, and the second one Pac
Expand Down
Loading