Add warn for selecting limit reduction with groups (not implemented)#1370
Closed
NathanDissoubray wants to merge 87 commits intomainfrom
Closed
Add warn for selecting limit reduction with groups (not implemented)#1370NathanDissoubray wants to merge 87 commits intomainfrom
NathanDissoubray wants to merge 87 commits intomainfrom
Conversation
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
…1286) Signed-off-by: Clement Philipot <clement.philipot@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
# Conflicts: # pom.xml
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
# Conflicts: # pom.xml # src/main/java/com/powsybl/openloadflow/dc/fastdc/AbstractComputedElement.java # src/main/java/com/powsybl/openloadflow/sa/AbstractSecurityAnalysis.java # src/main/java/com/powsybl/openloadflow/sensi/OpenSensitivityAnalysisProvider.java # src/test/java/com/powsybl/openloadflow/sensi/AcSensitivityAnalysisTest.java
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
# Conflicts: # src/main/java/com/powsybl/openloadflow/dc/fastdc/ComputedElement.java # src/main/java/com/powsybl/openloadflow/sa/WoodburyDcSecurityAnalysis.java
Signed-off-by: NathanDissoubray <nathan.dissoubray@rte-france.com>
olperr1
previously approved these changes
Mar 17, 2026
Signed-off-by: Sylvestre Prabakaran <sylvestre.prabakaran@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
…(powsybl-core 3670) (#1375) Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Signed-off-by: Sylvestre Prabakaran <sylvestre.prabakaran@rte-france.com>
Signed-off-by: Sylvestre Prabakaran <sylvestre.prabakaran@rte-france.com>
Signed-off-by: Sylvestre Prabakaran <sylvestre.prabakaran@rte-france.com>
Signed-off-by: Sylvestre Prabakaran <sylvestre.prabakaran@rte-france.com>
Signed-off-by: Sylvestre Prabakaran <sylvestre.prabakaran@rte-france.com>
…_selection_not_implemented
|
Author
|
I'm not sure how it's counting 83%, because when looking at the coverage of |
Member
It also considers all the changes of the |
Author
|
That's strange, since I'm merging this PR in |
4 tasks
Member
|
Closing this PR since #1379 has been merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixes #1358
What kind of change does this PR introduce?
Disable group selection for limit reduction, introduced by powsybl/powsybl-core#3802
What is the current behavior?
There is no implementation to support this in OLF.
What is the new behavior (if this is a feature change)?
The implementation is to disable it for now. It is supposed to be developped for the release in June. This is a temporary warn message for users for the march release.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information:
Waiting for merge of
sensi_operator_strategyinto main