[WIP] DC hot start#1360
Draft
gautierbureau wants to merge 1 commit intomainfrom
Draft
Conversation
ae235c9 to
ec3512b
Compare
Member
Author
|
Related to this subject I have two interrogations:
|
Member
|
Hello @gautierbureau , thank you, I'll have some time to review it after the march release. I may have some ideas in order not to modify too much the current architecture of LfBus (maybe by creating a new class extending AbstactLfInjection to model these loss injections), and also maybe a new kind of DcEquationTerm can be created for that. For the wanted outputs (admittance and losses), can't it be easyly computed from the result of such a load flow ? Or are there performance constraints that make you need that directly ? (Maybe I am wrong since I did not take time to read it accurately) |
Signed-off-by: Gautier Bureau <gautier.bureau@rte-france.com>
ec3512b to
d625bb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: