-
Notifications
You must be signed in to change notification settings - Fork 11
[Draft] Improve fast DC AS performances #1169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
annetill
wants to merge
42
commits into
main
Choose a base branch
from
improve_dc_woodbury_perfs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 18 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
5178daa
Improve DC Woodbury security analysis performances
geofjamg 4d951e9
Wip
geofjamg 34bb1f5
Wip
geofjamg e1406d3
Wip
geofjamg 7e94f45
Wip
geofjamg 9bfd926
Wip
geofjamg 747756c
Wip
geofjamg a280b22
Fix
geofjamg 48808a6
Wip
geofjamg b47022a
Wip
geofjamg 0774511
Wip
geofjamg 31ed43d
Wip
geofjamg a30d09c
Wip
geofjamg a8fa649
Proposal target vector management.
annetill 5759829
Wip
geofjamg 1c0525b
Wip
geofjamg eb6c3d8
Fix.
annetill c333e69
Merge remote-tracking branch 'origin/improve_dc_woodbury_perfs' into …
annetill 4ba6add
Merge branch 'refs/heads/main' into improve_dc_woodbury_perfs
p-arvy 5a49a59
Merge branch 'refs/heads/main' into improve_dc_woodbury_perfs
p-arvy 4a3f794
Add proposition to add pst actions in NetworkDcVectorState
p-arvy 3b5217d
Add proposition to remove branch result when branch is disabled
p-arvy fcceedb
Merge branch 'refs/heads/main' into improve_dc_woodbury_perfs
p-arvy bb82615
wip
p-arvy 3f9c50b
wip
p-arvy b847854
wip
p-arvy 26d7b30
Merge branch 'refs/heads/main' into improve_dc_woodbury_perfs
p-arvy 3d5cda3
wip
p-arvy 7b8e5c0
Merge branch 'refs/heads/main' into improve_dc_woodbury_perfs
p-arvy 016358d
Avoid creating breanch result if disabled
p-arvy 185187a
Merge branch 'refs/heads/main' into improve_dc_woodbury_perfs
p-arvy 2ceafa6
Clean
p-arvy 3cf3717
Use NetworkDcVectorState to calculate pre contingency results
p-arvy 5e5da40
Merge branch 'refs/heads/main' into improve_dc_woodbury_perfs
p-arvy 77f1eba
wip
p-arvy 0d1cdea
Only evaluate violations if most restricted limit is violated
p-arvy 4f68f8e
clean
p-arvy 4307ce6
Merge branch 'refs/heads/main' into improve_dc_woodbury_perfs
p-arvy daca8e9
Clean
p-arvy e740167
Add hvdc without power in ConnectivityAnalysisResult
p-arvy 1944147
Refactor WoodburyDcSecurityAnalysis
p-arvy 975e20a
small clean
p-arvy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@p-arvy here is why we stop, as slack distribution keys have changed, the trajet vector has to be updated. Doing it by hand is really complex and in a way a code duplication, so it could be nice if you test a DC network save/restore with the less possible number of fields (only buses, some branches, all branches, which attributes inside).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay thank you for the feedback @annetill. I will take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @annetill, @geofjamg, my understanding is that we want to return to applying the
LfContingency, but this time saving/modifying/restoring the least possible number of fields.In doing so, I have the impression that it is sufficient to apply the generators/loads/hvdcs changes due to the
LfContingency, and save/restore theBusDcStateof theLfNetwork, as the impact of changes on other elements (lost buses/PSTs) is already accounted for in the RHS override by directly modifying the target vector array (in methodWoodburyEngine.runDcLoadFlowWithModifiedTargetVector). What do you think ?I have pushed a commit in this regard (note that the code is not yet clean). Please feel free to comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also rolled back to have the case distinction when the contingency causes generator/load losses or not (to avoid having to save/apply/restore the modifications). This reduces significantly execution time in case of branch contingencies.