Skip to content

Look for .zshrc in ZDOTDIR if defined #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eikaas wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Look for .zshrc in ZDOTDIR if defined #71

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebb3b9a
Look for .zshrc in ZDOTDIR if its defined
eikaas Oct 18, 2018
da48f50
Fixes logic and adds documentation
eikaas Oct 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion cmd/install/install.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ func installers() (i []installer) {
break
}
}
if f := rcFile(".zshrc"); f != "" {
if f := zshrcPath(); f != "" {
i = append(i, zsh{f})
}
if d := fishConfigDir(); d != "" {
Expand All @@ -74,6 +74,16 @@ func installers() (i []installer) {
return
}

func zshrcPath() string {
Comment thread
posener marked this conversation as resolved.
if zDotDir := os.Getenv("ZDOTDIR"); zDotDir != "" {
f := filepath.Join(zDotDir, ".zshrc")
if info, err := os.Stat(f); err != nil || !info.IsDir() {
Copy link
Copy Markdown
Owner

@posener posener Oct 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err == nil && !info.IsDir()?

Copy link
Copy Markdown
Author

@eikaas eikaas Oct 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is completely wrong. Updated it

return f
}
}
return rcFile(".zshrc")
}

func fishConfigDir() string {
configDir := filepath.Join(getConfigHomePath(), "fish")
if configDir == "" {
Expand Down