sync: do not clobber bootstrap settings#1447
Merged
Merged
Conversation
In the all-in-one mode, certain bootstrap settings are passed to Pomerium Core using an in-memory ConfigSource. Currently the APIReconciler is unaware of these bootstrap settings, and when it syncs a settings entity via the API it will fill in the Core defaults. This is a problem for the 'address' setting, which is set to :8443 for all-in-one mode, and is different from the Core default of :443. If the bootstrap setting is overridden, Pomerium Core won't be listening on the correct port and the pomerium-proxy Service in the kustomize configuration won't work correctly. Instead, let's add a parameter to NewAPIReconciler() to make these bootstrap settings available to the API sync logic. The sync logic will apply all of the Pomerium CRD settings on top of these base settings. The standalone mode can continue to use the Core defaults as before.
calebdoxsey
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the all-in-one mode, certain bootstrap settings are passed to Pomerium Core using an in-memory ConfigSource. Currently the APIReconciler is unaware of these bootstrap settings, and when it syncs a settings entity via the API it will fill in the Core defaults.
This is a problem for the
addresssetting, which is set to :8443 for all-in-one mode, and is different from the Core default of :443. If the bootstrap setting is overridden, Pomerium Core won't be listening on the correct port and thepomerium-proxyService in the kustomize configuration won't work correctly.Instead, let's add a parameter to NewAPIReconciler() to make these bootstrap settings available to the API sync logic. The sync logic will apply all of the Pomerium CRD settings on top of these base settings.
The standalone mode can continue to use the Core defaults as before.
Related issues
https://linear.app/pomerium/issue/ENG-4148/ingress-controller-intermittent-connection-refused-errors-in-api-sync
Checklist
improvement/bug/ etc)