Skip to content

sync: query filter should use snake_case #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenjenkins merged 1 commit into from
Jun 15, 2026
Merged

sync: query filter should use snake_case #1442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pomerium/sync_api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,8 +676,8 @@ func (r *APIReconciler) findRouteByName(
ctx context.Context, name string,
) (existing *configpb.Route, err error) {
filter, err := structpb.NewStruct(map[string]any{
"originatorId": originatorID,
"name": name,
"originator_id": originatorID,
"name": name,
})
if err != nil {
return nil, fmt.Errorf("internal error - couldn't create ListRoutes filter: %w", err)
Expand Down Expand Up @@ -813,8 +813,8 @@ func (r *APIReconciler) findPolicyByName(
ctx context.Context, name string,
) (existing *configpb.Policy, err error) {
filter, err := structpb.NewStruct(map[string]any{
"originatorId": originatorID,
"name": name,
"originator_id": originatorID,
"name": name,
})
if err != nil {
return nil, fmt.Errorf("internal error - couldn't create ListPolicies filter: %w", err)
Expand Down Expand Up @@ -917,8 +917,8 @@ func (r *APIReconciler) findKeyPairByName(
ctx context.Context, name string,
) (existing *configpb.KeyPair, err error) {
filter, err := structpb.NewStruct(map[string]any{
"originatorId": originatorID,
"name": name,
"originator_id": originatorID,
"name": name,
})
if err != nil {
return nil, fmt.Errorf("internal error - couldn't create ListKeyPairs filter: %w", err)
Expand Down
4 changes: 2 additions & 2 deletions pomerium/sync_api_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1675,8 +1675,8 @@ func (noopBackendRefChecker) Valid(_ client.Object, _ *gateway_v1.BackendRef) bo

func filterByName(t *testing.T, name string) *structpb.Struct {
f, err := structpb.NewStruct(map[string]any{
"originatorId": "ingress-controller",
"name": name,
"originator_id": "ingress-controller",
"name": name,
})
require.NoError(t, err)
return f
Expand Down
Loading