Skip to content

Remove loading/unloading of plugins after startup #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gartens wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Remove loading/unloading of plugins after startup #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d323c78
Clean up the PolyPluginManager
gartens Mar 6, 2026
fac80fe
Remove loading plugins over the web-interface
gartens Mar 9, 2026
9adc513
Remove unused config variables
gartens Mar 9, 2026
25188c2
Small improvements
gartens Mar 9, 2026
da3aee7
Add back enough for the RuntimeConfig such that the WebUI still works
gartens Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/src/main/java/org/polypheny/db/config/Config.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ public Feedback setConfigObjectList( final List<Object> values, Class<? extends
}


public void setList( List<ConfigScalar> values ) {
public void setList( List<? extends ConfigScalar> values ) {
throw new ConfigRuntimeException( "Not possible to set a list on a configuration element of type " + this.getClass().getSimpleName() + "!" );
}

Expand Down
4 changes: 2 additions & 2 deletions config/src/main/java/org/polypheny/db/config/ConfigList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,13 +283,13 @@ public Feedback setConfigObjectList( List<Object> values, Class<? extends Config


@Override
public void setList( List<ConfigScalar> values ) {
public void setList( List<? extends ConfigScalar> values ) {
if ( requiresRestart() ) {
if ( this.oldList == null ) {
this.oldList = this.list;
}
}
this.list = values;
this.list = values.stream().map( v -> (ConfigScalar) v ).toList();
values.forEach( val -> val.addObserver( listener ) );
if ( this.oldList != null && this.oldList.equals( this.list ) ) {
this.oldList = null;
Expand Down
14 changes: 2 additions & 12 deletions core/src/main/java/org/polypheny/db/config/RuntimeConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ public enum RuntimeConfig {

AVAILABLE_PLUGINS(
"runtime/availablePlugins",
"All plugins, which are available, be it active, only loaded or unloaded.",
"All plugins which are loaded.",
List.of(),
ConfigType.PLUGIN_LIST,
"pluginsGroup"
Expand All @@ -510,16 +510,6 @@ public enum RuntimeConfig {
"workflowsSettingsGroup"
),

BLOCKED_PLUGINS(
"runtime/blockedPlugins",
"All plugins, which are blocked by default.",
List.of( "druid-adapter",
"elasticsearch-adapter",
"geode-adapter",
"html-adapter",
"pig-adapter" ),
ConfigType.STRING_LIST
),

INSTANCE_UUID(
"runtime/uuid",
Expand Down Expand Up @@ -818,7 +808,7 @@ public void setString( final String value ) {
}


public void setList( final List<ConfigScalar> values ) {
public void setList( final List<? extends ConfigScalar> values ) {
configManager.getConfig( key ).setList( values );
}

Expand Down
Loading
Loading