Skip to content

ResourcePacksInfoPacket: Added missing setter#316

Open
ItzxDwi wants to merge 4 commits into
pmmp:masterfrom
ItzxDwi:patch-1
Open

ResourcePacksInfoPacket: Added missing setter#316
ItzxDwi wants to merge 4 commits into
pmmp:masterfrom
ItzxDwi:patch-1

Conversation

@ItzxDwi
Copy link
Copy Markdown

@ItzxDwi ItzxDwi commented Jun 23, 2025

@ItzxDwi ItzxDwi requested a review from a team as a code owner June 23, 2025 00:12
Comment thread src/ResourcePacksInfoPacket.php Outdated
@ItzxDwi ItzxDwi requested a review from dktapps June 24, 2025 01:51
@ItzxDwi
Copy link
Copy Markdown
Author

ItzxDwi commented Jul 14, 2025

someday 🙏

@dktapps
Copy link
Copy Markdown
Member

dktapps commented Jul 14, 2025

As I mentioned in pmmp/PocketMine-MP#6739, we don't actually need this API since you can just create a new packet and use DataPacketSendEvent::setPackets(). There's some uncertainty within the team about whether to allow mutating this, since we've been moving towards immutable packets for some time now.

@dktapps
Copy link
Copy Markdown
Member

dktapps commented Oct 20, 2025

Related to #330

@JaxkDev
Copy link
Copy Markdown

JaxkDev commented Apr 3, 2026

Just bumping this as a plugins come in, with its whole purpose of reflecting forceDisableVibrantVisuals to change it to true.
(Yeah they could rebuild it and set the packets in the event etc)

But after checking with dries, not sure why this field was private to begin with? especially if this PR adds a setter, seems like it should be changed to public. (leave the getter for BC if you really want)

Or was this intentionally private as all? fields now get added as private with getter?

@dktapps
Copy link
Copy Markdown
Member

dktapps commented Apr 3, 2026

See #330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API to control Vibrant Visuals

4 participants