Skip to content

fix: resolve rust CI clippy failures in memory API sorting #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: resolve rust CI clippy failures in memory API sorting #163

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd2887b
Initial plan
Copilot May 11, 2026
53d6456
fix: replace unnecessary sort_by calls in memory API
Copilot May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src-tauri/src/memory/api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ impl MemoryStore {
}

// Sort by started_at descending
sessions.sort_by(|a, b| b.started_at.cmp(&a.started_at));
sessions.sort_by_key(|session| std::cmp::Reverse(session.started_at));

Ok(sessions)
}
Expand Down Expand Up @@ -122,7 +122,7 @@ impl MemoryStore {
}

// Sort by timestamp descending
errors.sort_by(|a, b| b.timestamp.cmp(&a.timestamp));
errors.sort_by_key(|error| std::cmp::Reverse(error.timestamp));

// Apply limit
if let Some(limit) = limit {
Expand Down Expand Up @@ -175,7 +175,7 @@ impl MemoryStore {
}
}
}
commands.sort_by(|a, b| a.started_at.cmp(&b.started_at));
commands.sort_by_key(|command| command.started_at);

// Get outputs for these commands
let output_keys = self.client.list("memory:output:").await?;
Expand All @@ -197,7 +197,7 @@ impl MemoryStore {
}
}
}
outputs.sort_by(|a, b| a.chunk_index.cmp(&b.chunk_index));
outputs.sort_by_key(|output| output.chunk_index);

// Get errors in time window
let error_keys = self.client.list("memory:error:").await?;
Expand All @@ -220,7 +220,7 @@ impl MemoryStore {
}
}
}
errors.sort_by(|a, b| a.timestamp.cmp(&b.timestamp));
errors.sort_by_key(|error| error.timestamp);

// Get insights
let insight_keys = self.client.list("memory:insight:").await?;
Expand All @@ -243,7 +243,7 @@ impl MemoryStore {
}
}
}
insights.sort_by(|a, b| a.generated_at.cmp(&b.generated_at));
insights.sort_by_key(|insight| insight.generated_at);

Ok(ContextWindow {
session_id: session_id.to_string(),
Expand Down