Skip to content

Added GitHub Action for CI: #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chris-godz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added GitHub Action for CI: #56

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
163e2f7
Added GitHub Action for CI:
Chris-godz Mar 24, 2025
5779695
Fix: Rename TARGET to QEMU_TARGET
Chris-godz Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mkconfigs/qemu/qemu-hello.mk
View file
Open in desktop
Copy link
Copy Markdown
Collaborator

@unicornx unicornx Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是一个 bugfix，应该单独提一个 pr。不建议和这个 pr 一起提交。
我已经提了一个 issue：#57

Copy link
Copy Markdown
Collaborator

@BernardXiong BernardXiong May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否应该移除这个文件的修改？

Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ QCFLAGS := $(QCFLAGS) $(DEVICE) $(DEFINE) $(DEBUG)
ASFLAGS := $(ASFLAGS) $(DEVICE) $(DEFINE) $(DEBUG)
LDFLAGS := -T $(BOARD_PATH)/qemu/$(QEMU_BOARD)/link.ld $(LDFLAGS)

TARGET := $(QEMU_BOARD).elf
QEMU_TARGET := $(QEMU_BOARD).elf

$(QEMU_CRTOBJ_DIR)/%.o: $(PROJECT_PATH)/crt/$(ARCH)/%.c
$(CC) -c $(QEMU_INC) $(QCFLAGS) -o $@ $<
Expand All @@ -45,7 +45,7 @@ $(QEMU_OBJ_DIR)/%.o: $(BOARD_PATH)/%.c
$(CC) -c $(QEMU_INC) $(QCFLAGS) -o $@ $<

.PHONY:qemu-hello
qemu-hello: creat_qdir $(BOARD_PATH)/qemu/$(QEMU_BOARD)/$(TARGET)
qemu-hello: creat_qdir $(BOARD_PATH)/qemu/$(QEMU_BOARD)/$(QEMU_TARGET)

.PHONY: creat_qdir
creat_qdir:
Expand All @@ -57,5 +57,5 @@ else
@mkdir -p $(QEMU_OBJ_DIR)
endif

$(BOARD_PATH)/qemu/$(QEMU_BOARD)/$(TARGET): $(QEMU_CRTOBJ_FILES) $(QEMU_OBJ_FILES)
$(BOARD_PATH)/qemu/$(QEMU_BOARD)/$(QEMU_TARGET): $(QEMU_CRTOBJ_FILES) $(QEMU_OBJ_FILES)
$(CC) -o $@ $(QEMU_OBJ_FILES) $(QEMU_CRTOBJ_FILES) $(LDFLAGS)