Add Python version requirements and classifiers to setup.py#729
Open
SoohanBae wants to merge 3 commits into
Open
Add Python version requirements and classifiers to setup.py#729SoohanBae wants to merge 3 commits into
SoohanBae wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds Python version requirements and appropriate classifiers to facilitate dependency management and improve package metadata on PyPI, while also updating the package version.
- Added python_requires and classifiers in setup.py.
- Updated the version value in the plugin’s init.py.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| setup.py | Added python version requirement and classifiers. |
| plugins/PY/pinpointPy/init.py | Updated version and maintained module interface. |
Comments suppressed due to low confidence (1)
plugins/PY/pinpointPy/init.py:32
- There appears to be a missing comma between 'use_thread_local_context' and 'set_agent' in the all list, which could inadvertently concatenate the two strings.
__all__ = ['monkey_patch_for_pinpoint', 'use_thread_local_context' 'set_agent', 'app_id', 'app_name', 'gen_tid', 'get_logger', 'PinTransaction', 'GenPinHeader', 'PinHeader']
Contributor
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review