Catch Throwable instead of Exception in CallCenter#667
Open
ranpafin wants to merge 1 commit into
Open
Conversation
…wn errors When a promise throws a Throwable that is not an Exception (e.g. TypeError, Error), the CallCenter catch block missed it, so the call was never recorded. This aligns CallCenter and Call with ThrowPromise which already supports Throwable. Fixes phpspec#595
Contributor
|
Prophecy is a highly opiniated framework. I think not catching throwable is part of it since you should never throw PHP errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a promise throws a Throwable that is not an Exception (e.g. TypeError),
CallCenter does not catch it, so the call is never recorded.
This changes the catch block in CallCenter and the type hint in Call from
Exception to Throwable, aligning them with ThrowPromise which already
accepts Throwable.
Closes #595