Skip to content

Optimize LiveView async PID collection #4235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
preciz wants to merge 1 commit into from
Closed

Optimize LiveView async PID collection #4235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions lib/phoenix_live_view/channel.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1685,9 +1685,11 @@ defmodule Phoenix.LiveView.Channel do
defp component_asyncs(state) do
%{components: {components, _ids, _}} = state

Enum.reduce(components, %{}, fn {cid, {_mod, _id, _assigns, private, _prints}}, acc ->
Map.merge(acc, socket_asyncs(private, cid))
end)
for {cid, {_mod, _id, _assigns, %{live_async: ref_pids}, _prints}} <- components,
{key, {ref, pid, kind}} <- ref_pids,
into: %{} do
{pid, {key, ref, cid, kind}}
end
end

defp all_asyncs(state) do
Expand All @@ -1698,13 +1700,9 @@ defmodule Phoenix.LiveView.Channel do
|> Map.merge(component_asyncs(state))
end

defp socket_asyncs(private, cid) do
case private do
%{live_async: ref_pids} ->
Enum.into(ref_pids, %{}, fn {key, {ref, pid, kind}} -> {pid, {key, ref, cid, kind}} end)

%{} ->
%{}
end
defp socket_asyncs(%{live_async: ref_pids}, cid) do
Map.new(ref_pids, fn {key, {ref, pid, kind}} -> {pid, {key, ref, cid, kind}} end)
end

defp socket_asyncs(%{}, _cid), do: %{}
end
Loading