Skip to content

Clarify JS display defaults #4234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteffenDE merged 1 commit into from
May 16, 2026
Merged

Clarify JS display defaults #4234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/phoenix_live_view/js.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,8 @@ defmodule Phoenix.LiveView.JS do
* `:time` - The time in milliseconds to apply the transition `:in` and `:out` classes.
Defaults to #{@default_transition_time}.
* `:display` - An optional display value to set when toggling in. Defaults
to `"block"`.
to `"block"`, except for table rows and cells, which default to `"table-row"`
and `"table-cell"`.
* `:blocking` - A boolean flag to block the UI during the transition. Defaults `true`.

When the toggle is complete on the client, a `phx:show-start` or `phx:hide-start`, and
Expand Down Expand Up @@ -577,7 +578,9 @@ defmodule Phoenix.LiveView.JS do
* `:time` - The time in milliseconds to apply the transition from `:transition`.
Defaults to #{@default_transition_time}.
* `:blocking` - A boolean flag to block the UI during the transition. Defaults `true`.
* `:display` - An optional display value to set when showing. Defaults to `"block"`.
* `:display` - An optional display value to set when showing. Defaults to
`"block"`, except for table rows and cells, which default to `"table-row"`
and `"table-cell"`.

During the process, the following events will be dispatched to the shown elements:

Expand Down
Loading