Optimize Rendered iodata materialization #4232
Merged
Annotations
1 error, 2 warnings, and 1 notice
|
Run e2e tests:
test/e2e/tests/uploads.spec.js#L230
1) [chromium] › tests/uploads.spec.js:202:1 › issue 3115 - cancelled upload is not re-added ──────
Error: expect(locator).toHaveCount(expected) failed
Locator: locator('ul li')
Expected: 1
Received: 2
Timeout: 5000ms
Call log:
- Expect "toHaveCount" with timeout 5000ms
- waiting for locator('ul li')
9 × locator resolved to 2 elements
- unexpected value "2"
228 |
229 | // we should see one uploaded file in the list
> 230 | await expect(page.locator("ul li")).toHaveCount(1);
| ^
231 | });
232 |
233 | test("submitting invalid form multiple times doesn't crash", async ({
at /__w/phoenix_live_view/phoenix_live_view/test/e2e/tests/uploads.spec.js:230:39
|
|
.github/workflows/ci.yml#L75
.github/workflows/ci.yml (Line: 75, Col: 13): Conditional expression contains literal text outside replacement tokens. This will cause the expression to always evaluate to truthy. Did you mean to put the entire expression inside ${{ }}?
|
|
Complete job
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@v4, actions/checkout@v4, actions/upload-artifact@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Run e2e tests
1 flaky
[chromium] › tests/uploads.spec.js:202:1 › issue 3115 - cancelled upload is not re-added ───────
6 skipped
533 passed (4.6m)
|
background
wait
wait-all
cancel
Loading