Optimize route path splitting with trim: true#4230
Closed
preciz wants to merge 1 commit into
Closed
Conversation
Replace list comprehension filter with `trim: true` option in `String.split/3` when parsing LiveView route paths. Benchee shows a small speedup with consistently lower memory use.
Member
|
At this level, I'm not sure it matters, but appreciate the look. If you want to follow up with benchy results please do, but we'd need a particularly good signal on the delta for small optimizations like this to justify the churn. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace list comprehension filter with
trim: trueoption inString.split/3when parsing LiveView route paths.Benchee shows a small speedup with consistently lower memory use.