feat: Detect Implicit Object Creation (Mock<T> myMock = new())

[Brian Collamore (bcollamore)]

No description provided.

[Copilot]

Pull request overview

This PR updates the Moq disposable-mock analyzer/code-fix to detect target-typed implicit object creation (new()) and modernizes the Roslyn package versions needed to support that syntax.

Changes:

• Extend MockDisposableClassesShouldSetupDisposeAnalyzer to analyze ImplicitObjectCreationExpression in addition to explicit new Mock<T>().
• Update the Moq code fix and tests to cover target-typed new() cases.
• Bump Roslyn-related NuGet packages (and adapt test helpers) to newer APIs; apply small IsKind(...) refactors across analyzers/code fixes.

Reviewed changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
Philips.CodeAnalysis.MoqAnalyzers/MockDisposableClassesShouldSetupDisposeAnalyzer.cs	Register syntax actions for implicit object creation and resolve mocked type via semantic model.
Philips.CodeAnalysis.MoqAnalyzers/MockDisposableClassesShouldSetupDisposeCodeFixProvider.cs	Broaden code fix node handling to ExpressionSyntax and add a branch for implicit new().
Philips.CodeAnalysis.Test/Moq/MockDisposableClassesShouldSetupDisposeAnalyzerTest.cs	Add analyzer tests for Mock<T> x = new(); patterns.
Philips.CodeAnalysis.Test/Moq/MockDisposableClassesShouldSetupDisposeCodeFixProviderTest.cs	Add code-fix tests for target-typed new() and argumented new(...).
Philips.CodeAnalysis.Test/Verifiers/DiagnosticVerifier.Helper.cs	Implement AnalyzerConfigOptionsProvider.GlobalOptions for newer Roslyn APIs.
Philips.CodeAnalysis.Test/Helpers/TestAnalyzerConfigOptionsProvider.cs	Implement AnalyzerConfigOptionsProvider.GlobalOptions for newer Roslyn APIs.
Philips.CodeAnalysis.Test/Philips.CodeAnalysis.Test.csproj	Update Roslyn workspace package reference version.
Philips.CodeAnalysis.Common/Philips.CodeAnalysis.Common.csproj	Update Roslyn workspace package reference version.
Directory.Build.Analyzer.props	Update Microsoft.CodeAnalysis.Analyzers and Roslyn workspace package reference.
Philips.CodeAnalysis.Benchmark/Philips.CodeAnalysis.Benchmark.csproj	Update Microsoft.CodeAnalysis package reference version.
Philips.CodeAnalysis.MsTestAnalyzers/TestMethodNameCodeFixProvider.cs	Update rename API usage to SymbolRenameOptions and newer Renamer overload.
Philips.CodeAnalysis.MsTestAnalyzers/TestMethodNameAnalyzer.cs	Replace Kind() comparisons with IsKind(...).
Philips.CodeAnalysis.MsTestAnalyzers/AvoidAssertConditionalAccessAnalyzer.cs	Replace Kind() comparisons with IsKind(...).
Philips.CodeAnalysis.MaintainabilityAnalyzers/Maintainability/NoRegionsInMethodAnalyzer.cs	Refactor region detection to traverse directive trivia; add required usings.
Philips.CodeAnalysis.Test/Maintainability/Maintainability/NoRegionsInMethodAnalyzerTest.cs	Adjust test inputs/expectations for region directive detection behavior.
Philips.CodeAnalysis.MaintainabilityAnalyzers/Maintainability/ProhibitDynamicKeywordAnalyzer.cs	Fix message typo and adjust dynamic detection implementation.
Philips.CodeAnalysis.Test/Maintainability/Maintainability/ProhibitDynamicKeywordAnalyzerTest.cs	Update test snippets to be compilable as complete types.
Philips.CodeAnalysis.MaintainabilityAnalyzers/Documentation/XmlDocumentationCodeFixProvider.cs	Replace Kind() comparisons with IsKind(...).
Philips.CodeAnalysis.Test/Maintainability/Documentation/XmlDocumentationShouldAddValueAnalyzerTest.cs	Update test content scaffolding to include required type context.
Philips.CodeAnalysis.MaintainabilityAnalyzers/RuntimeFailure/DereferenceNullAnalyzer.cs	Replace Kind() comparisons with IsKind(...).
Philips.CodeAnalysis.MaintainabilityAnalyzers/Readability/PreventUnnecessaryRangeChecksAnalyzer.cs	Replace Kind() comparisons with IsKind(...).
Philips.CodeAnalysis.MaintainabilityAnalyzers/Readability/PreferNamedTuplesAnalyzer.cs	Replace Kind() comparisons with IsKind(...).
Philips.CodeAnalysis.MaintainabilityAnalyzers/Naming/VariableNamingConventionAnalyzer.cs	Replace Kind() comparisons with IsKind(...).
Philips.CodeAnalysis.MaintainabilityAnalyzers/Naming/EnforceBoolNamingConventionAnalyzer.cs	Replace Kind() comparisons with IsKind(...).
Philips.CodeAnalysis.MaintainabilityAnalyzers/Maintainability/MergeIfStatementsAnalyzer.cs	Replace Kind() comparisons with IsKind(...).
Philips.CodeAnalysis.MaintainabilityAnalyzers/Maintainability/AvoidStaticMethodAnalyzer.cs	Replace Kind() comparisons with IsKind(...).
Philips.CodeAnalysis.MaintainabilityAnalyzers/Maintainability/AvoidStaticClassesAnalyzer.cs	Replace Kind() comparisons with IsKind(...).
Philips.CodeAnalysis.MaintainabilityAnalyzers/Maintainability/AvoidPublicMemberVariableAnalyzer.cs	Replace Kind() comparisons with IsKind(...).
Philips.CodeAnalysis.MaintainabilityAnalyzers/Maintainability/AvoidAsyncVoidAnalyzer.cs	Replace Kind() comparisons with IsKind(...).

[Alex Barga (ajbarga)]

FindCurrentNode is unnecessary and can be removed

I traced the call path and verified locally that FindCurrentNode (lines 88-98 of the code fix provider) is dead complexity:

1. The base class SingleDiagnosticCodeFixProvider<TSyntax>.RegisterCodeFixesAsync obtains the syntax root, finds node from it via GetNode, then passes the same document to ApplyFix.
2. Inside ApplyFix, document.GetSyntaxRootAsync() returns the Roslyn-cached root — the same tree instance that node already belongs to.
3. Re-locating the node by span via FindNode is redundant. Worse, getInnermostNodeForTie: true could return a node of a different type than expected, causing the as TNode cast to return null and the fix to silently bail out.

I removed FindCurrentNode entirely, used node directly, and all 35 tests (analyzer + code fix, including implicit new() and fix-all) still pass. The diff is minimal:

-			ExpressionSyntax currentNode = FindCurrentNode<ExpressionSyntax>(rootNode, node);
-			if (currentNode == null)
-			{
-				return document;
-			}
-
-			TypeSyntax declaredTypeToReplace = GetDeclaredTypeFromContext(currentNode);
-
-			if (currentNode is ImplicitObjectCreationExpressionSyntax)
+			TypeSyntax declaredTypeToReplace = GetDeclaredTypeFromContext(node);
+
+			if (node is ImplicitObjectCreationExpressionSyntax)

-			if (currentNode is ObjectCreationExpressionSyntax explicitObjectCreation &&
+			if (node is ObjectCreationExpressionSyntax explicitObjectCreation &&

And delete the FindCurrentNode method entirely.

[Alex Barga (ajbarga)]

Brian Collamore (@bcollamore) clearly those suggestions had error, apologies. Resolved.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
82.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud