Skip to content

Auth as app#88

Draft
Marco Franssen (marcofranssen) wants to merge 5 commits into
developfrom
auth-as-app
Draft

Auth as app#88
Marco Franssen (marcofranssen) wants to merge 5 commits into
developfrom
auth-as-app

Conversation

@marcofranssen
Copy link
Copy Markdown
Member

@marcofranssen Marco Franssen (marcofranssen) commented Jan 20, 2021

This PR adds authenticating tabia as a Github App.

Current implementation will limit the GitHub App authentication to a single organization, whereas the token based auth allows to fetch information from multiple organizations at a time.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 20, 2021

Codecov Report

❌ Patch coverage is 60.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.21%. Comparing base (b39b7a5) to head (a34b1d0).
⚠️ Report is 295 commits behind head on develop.

Files with missing lines Patch % Lines
lib/github/app.go 60.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #88      +/-   ##
===========================================
- Coverage    66.66%   66.21%   -0.46%     
===========================================
  Files           17       18       +1     
  Lines          408      438      +30     
===========================================
+ Hits           272      290      +18     
- Misses         117      129      +12     
  Partials        19       19              
Flag Coverage Δ
unittests 66.21% <60.00%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant