Fix greasefang (delayed triggers that trigger at the beginning of "your next end step")#80
Open
scherven wants to merge 12 commits intophase-rs:mainfrom
Open
Fix greasefang (delayed triggers that trigger at the beginning of "your next end step")#80scherven wants to merge 12 commits intophase-rs:mainfrom
scherven wants to merge 12 commits intophase-rs:mainfrom
Conversation
…to fix-greasefang
Contributor
|
Hey @scherven - apologize for the delay here. I was actually working on Greasefang last week and thought this might end up redundant. If we can resolve the conflicts I can look to see if there's anything else applicable here, such as the target referencing you mentioned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, only "the next end step" was handled. Also, allow delayed triggered abilities to correctly reference the previous target when they're linked to another triggered ability.