Fixed timer lifespan in 2013 advent cal async example#18
Open
nrdvana wants to merge 1 commit into
Open
Conversation
This example appeared to work, but actually most requests were having their timer cut short by the next request, because there was only one global variable, and the program needed to hold refs to multiple concurrent timers. Solved in the simplest possible way by moving the timer ref inside the timer callback to create a circular reference, though aa better way would be to hold the timer ref in a global pool and not form the circular ref in the first place. But, that's more code...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This example appeared to work, but actually most requests were
having their timer cut short by the next request, because there
was only one global variable, and the program needed to hold
refs to multiple concurrent timers.
Solved in the simplest possible way by moving the timer ref
inside the timer callback to create a circular reference, though
aa better way would be to hold the timer ref in a global pool
and not form the circular ref in the first place. But, that's
more code...