PMM-15051 Wait for settings endpoint to be ready after public address update#5366
PMM-15051 Wait for settings endpoint to be ready after public address update#5366matejkubinec wants to merge 11 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates settings retrieval so the UI can wait for the settings endpoint to become available after changing the PMM public address.
Changes:
- Adds Axios request config support to
getSettings. - Passes optional Axios config through
useSettings. - Adds post-update polling in
useUpdateSettingswhen the public address changes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
ui/apps/pmm/src/types/api.types.ts |
Adds React Query option typing for Axios config. |
ui/apps/pmm/src/hooks/api/useSettings.ts |
Uses Axios config in settings queries and waits for settings readiness after public address changes. |
ui/apps/pmm/src/api/settings.ts |
Allows getSettings to receive Axios request config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@copilot fix the following issue with the type imports for the UseQueryDetails: |
Agent-Logs-Url: https://github.com/percona/pmm/sessions/66ca299a-20ee-4073-a410-2c08a5e3317e Co-authored-by: matejkubinec <32638572+matejkubinec@users.noreply.github.com>
|
|
|
@copilot remove unused imports |
Agent-Logs-Url: https://github.com/percona/pmm/sessions/1336d981-0808-4bce-9846-9eb9cb52f1f7 Co-authored-by: fabio-silva <4190654+fabio-silva@users.noreply.github.com>
PMM-15051
FB: SUBMODULES-4355