fix: route /victoriametrics writes through vmproxy (PMM-15030)#5323
Open
theTibi wants to merge 2 commits into
Open
fix: route /victoriametrics writes through vmproxy (PMM-15030)#5323theTibi wants to merge 2 commits into
theTibi wants to merge 2 commits into
Conversation
In external VictoriaMetrics mode, /victoriametrics/ still pointed to local 127.0.0.1:9090 and returned 502 for write requests. Route it through vmproxy to match /prometheus/api/v1 behavior. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: theTibi <tkorocz@gmail.com>
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #5323 +/- ##
==========================================
+ Coverage 42.19% 42.21% +0.02%
==========================================
Files 410 410
Lines 41914 41914
==========================================
+ Hits 17686 17696 +10
+ Misses 22441 22434 -7
+ Partials 1787 1784 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maxkondr
approved these changes
May 6, 2026
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PMM_VM_URLset), nginx still proxied/victoriametrics/to local127.0.0.1:9090/prometheus/, causing write-path failures./victoriametrics/throughvmproxy(http://vmproxy/prometheus/) to align with/prometheus/api/v1behavior.Ticket
Test plan
docker-compose.yml+docker-compose.dev.yml) and external VM mode configured.pmm-server:location /victoriametrics/ { proxy_pass http://vmproxy/prometheus/; }docker exec pmm-server nginx -t->syntax is okandtest is successfulcurl -k -u admin:admin -X POST https://127.0.0.1/victoriametrics/api/v1/write --data-binary testdata-> HTTP204