fix: valkey cluster messages panel use message rate (PMM-14894)#5318
Open
theTibi wants to merge 4 commits into
Open
fix: valkey cluster messages panel use message rate (PMM-14894)#5318theTibi wants to merge 4 commits into
theTibi wants to merge 4 commits into
Conversation
Use rate() with $__rate_interval on redis_cluster_messages_*_total counters so the graph is messages/s instead of cumulative totals. Set axis label and unit; clarify panel description. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: theTibi <tkorocz@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #5318 +/- ##
==========================================
- Coverage 43.22% 43.09% -0.14%
==========================================
Files 413 543 +130
Lines 42279 44627 +2348
Branches 0 584 +584
==========================================
+ Hits 18277 19231 +954
- Misses 22134 23464 +1330
- Partials 1868 1932 +64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
matejkubinec
requested review from
fabio-silva and
mattiasimonato
and removed request for
a team
matejkubinec
approved these changes
May 22, 2026
fabio-silva
approved these changes
May 22, 2026
mattiasimonato
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use rate() with $_rate_interval on redis_cluster_messages*_total counters so the graph is messages/s instead of cumulative totals. Set axis label and unit; clarify panel description.
PMM-14894
FB: SUBMODULES-4339