Fix-pmm-14971#5317
Draft
theTibi wants to merge 3 commits into
Draft
Conversation
When the iframe session expires (e.g. after password change), Grafana posts LOCATION_CHANGE to /graph/login. SPA navigate kept MainWithNav, so the sidebar stayed visible next to the login form. Use a top-level document navigation to /pmm-ui/graph/login and a dedicated route that renders only the Grafana iframe (no sidebar/header). Harden getLocationUrl so Grafana paths already under /graph are not doubled. Tests: vitest for getLocationUrl and isGrafanaLoginPath. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: theTibi <tkorocz@gmail.com>
Avoids a barrel cycle (pages/grafana index exporting both components). Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: theTibi <tkorocz@gmail.com>
React Router Path has no 'key'; strict build failed in ui#build. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: theTibi <tkorocz@gmail.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(ui): full-page Grafana login without PMM shell (PMM-14971)
When the iframe session expires (e.g. after password change), Grafana posts
LOCATION_CHANGE to /graph/login. SPA navigate kept MainWithNav, so the
sidebar stayed visible next to the login form.
Use a top-level document navigation to /pmm-ui/graph/login and a dedicated
route that renders only the Grafana iframe (no sidebar/header). Harden
getLocationUrl so Grafana paths already under /graph are not doubled.
If this PR is related to other PRs, contributions, or ongoing work in this or other repositories, please reference them here: