PMM-14985 Add Prometheus-native storage usage telemetry#5313
Open
4nte wants to merge 2 commits into
Open
Conversation
Track legacy Prometheus-native db usage
Contributor
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #5313 +/- ##
==========================================
+ Coverage 41.49% 41.58% +0.08%
==========================================
Files 410 410
Lines 41992 41914 -78
==========================================
+ Hits 17424 17429 +5
+ Misses 22814 22732 -82
+ Partials 1754 1753 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ademidoff
approved these changes
May 4, 2026
maxkondr
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-14985
Link to the Feature Build: Feature Build
Adds a new telemetry entry
VMPromDBSeriesReadPerQuerytomanaged/services/telemetry/config.default.yml.Telemetry reports the 24h average number of series read per query against the Prometheus-native (legacy promdb) store on PMM Server, computed as
sum(rate(vm_promdb_series_read_per_query_sum[24h])) / sum(rate(vm_promdb_series_read_per_query_count[24h])).This helps us understand real-world usage of the legacy promdb path so we can plan its deprecation/removal.
QA test harness
A self-contained, reproducible E2E harness lives in PMM-14985-test repository and verifies that the new VMPromDBSeriesReadPerQuery telemetry entry actually emits a non-zero value when promdb is in use, and exactly 0 when it isn't.
Harness repo must be cloned inside the local PMM repository, see instructions in test repo README.