Skip to content

Add ElastiCache auto-discovery for Valkey/Redis services #5303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
angelvilardellperez wants to merge 22 commits into
base: v3
Choose a base branch
from

fix: register RemoteElastiCacheNode in NodeTypeName map

60e3672
Select commit
Loading
Failed to load commit list.
Open

Add ElastiCache auto-discovery for Valkey/Redis services #5303

fix: register RemoteElastiCacheNode in NodeTypeName map
60e3672
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 21, 2026 in 0s

42.90% (-0.32%) compared to 138f6e5

View this Pull Request on Codecov

42.90% (-0.32%) compared to 138f6e5

Details

Codecov Report

❌ Patch coverage is 18.63118% with 428 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.90%. Comparing base (138f6e5) to head (60e3672).

Files with missing lines Patch % Lines
...naged/services/management/elasticache_discovery.go 24.22% 209 Missing and 10 partials ⚠️
managed/services/management/elasticache.go 1.07% 184 Missing ⚠️
managed/services/converters.go 0.00% 11 Missing ⚠️
managed/cmd/pmm-managed/main.go 0.00% 5 Missing ⚠️
managed/services/inventory/grpc/nodes_server.go 0.00% 4 Missing ⚠️
managed/services/inventory/nodes.go 92.30% 1 Missing and 1 partial ⚠️
managed/services/management/service.go 33.33% 2 Missing ⚠️
managed/models/agent_helpers.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##               v3    #5303      +/-   ##
==========================================
- Coverage   43.22%   42.90%   -0.32%     
==========================================
  Files         413      415       +2     
  Lines       42302    42826     +524     
==========================================
+ Hits        18283    18376      +93     
- Misses      22152    22572     +420     
- Partials     1867     1878      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov