PMM-14993 One step install by theTibi · Pull Request #894 · percona/grafana

theTibi · 2026-04-15T12:48:57Z

This pull request introduces a new "Add Node" quick-install feature to the Inventory Nodes tab, enabling users to easily add MySQL, PostgreSQL, MongoDB, or Valkey nodes with a single click. It provides a dropdown for technology selection, generates a secure short-lived install token, and copies a tailored shell command to the clipboard for execution on the target host. The implementation includes supporting utilities, UI enhancements, and robust error handling.

Feature: Add Node Quick-Install Command

Added a dropdown "Add Node" button with options for MySQL, PostgreSQL, MongoDB, and Valkey, each with appropriate icons and labels. Selecting an option generates a short-lived Grafana service account token, builds a shell command to install and register the node, and copies it to the clipboard. User feedback is provided for success and error cases. (Nodes.tsx, Nodes.constants.ts, Inventory.messages.ts, installToken.ts, [1] [2] [3] [4]
Implemented buildQuickInstallCommand utility to construct a secure, technology-specific install command, ensuring proper shell escaping and URL-encoding of tokens. (NodesInstallCommand.utils.ts, public/app/percona/inventory/Tabs/NodesInstallCommand.utils.tsR1-R37)
Added logic to create or reuse a Grafana service account per technology and mint a short-lived token for each install, aligning with previous backend behavior but using Grafana APIs directly. (installToken.ts, public/app/percona/inventory/installToken.tsR1-R132)

Testing and Reliability

Introduced comprehensive tests for the install command builder to verify correct escaping, token handling, and tech-specific flags. (NodesInstallCommand.utils.test.ts, public/app/percona/inventory/Tabs/NodesInstallCommand.utils.test.tsR1-R26)
Improved error handling and user notifications for token creation and clipboard operations. (Nodes.tsx, public/app/percona/inventory/Tabs/Nodes.tsxR367-R419)

UI/UX Enhancements

Updated styles for the action panel to accommodate the new button group and ensure responsive layout. (Tabs.styles.ts, public/app/percona/inventory/Tabs/Tabs.styles.tsL20-R23)
Added "More options…" link for advanced node addition and updated messages for new UI elements. (Nodes.tsx, Inventory.messages.ts, [1] [2]

These changes collectively streamline the node addition workflow and improve the user experience for managing inventory nodes.

Add primary control with MySQL/PostgreSQL/MongoDB menu items that copy a default one-line curl install command. Link to full /pmm-ui/install-client wizard for advanced options. Made-with: Cursor

Resolve stash onto one_step_install: use management API path for token, optional token in buildQuickInstallCommand, loading state and error message. Made-with: Cursor

Rename copy to match UX: primary dropdown is Add Node; menu order MySQL, MongoDB, PostgreSQL; clearer success and message keys. Made-with: Cursor

…eneration Introduce 'Valkey' as a new option in the Add Node menu. Update the QuickInstallTech type to include 'valkey' and modify the buildQuickInstallCommand function to align with the new installation process, ensuring proper command formatting and security options.

…e security Refactor the buildQuickInstallCommand function to download the install script to a temporary path before execution. This change enhances security by allowing the script to prompt for database credentials directly on the node. The command structure has been updated to reflect these changes, ensuring proper handling of environment variables and command flags. Signed-off-by: theTibi <tkorocz@gmail.com>

Copilot

Pull request overview

Adds a “one step install” flow to the Percona Inventory > Nodes tab by generating a quick-install command (with a freshly created install token) and copying it to the clipboard, while keeping an “advanced options” link available.

Changes:

Adds UI for “Add Node” as a dropdown by technology, generating/copying a quick-install command with an install token.
Introduces a utility to build the install command (download-then-run install-pmm-client.sh) and a management API path constant.
Adjusts action panel layout styles to accommodate the new controls.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
public/app/percona/inventory/Tabs/Tabs.styles.ts	Updates action panel flex layout to fit the new Add Node controls alongside existing actions.
public/app/percona/inventory/Tabs/NodesInstallCommand.utils.ts	New utility to generate the quick-install shell command (script download + execution + flags).
public/app/percona/inventory/Tabs/Nodes.tsx	Adds Add Node dropdown UI, token generation call, clipboard copy flow, and “More options…” link.
public/app/percona/inventory/managementApi.constants.ts	Adds a constant for the management endpoint path used to create install tokens.
public/app/percona/inventory/Inventory.messages.ts	Adds user-facing strings for the new Add Node dropdown and copy/token errors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…count token generation Add a new TypeScript file to handle the creation of short-lived Grafana service account tokens for the "Add Node" quick-install command. This implementation replaces the removed backend endpoint, directly utilizing Grafana's service accounts API. The previous management API constant for the token path has been removed, and the Nodes component has been updated to use the new token generation function. Signed-off-by: theTibi <tkorocz@gmail.com>

Update the installToken.ts file to replace hardcoded API paths with a new utility function, grafanaHttpApiUrl, which constructs the correct Grafana API URL based on the application's sub-path configuration. This change ensures that service-account API calls are correctly routed, improving maintainability and reducing the risk of 404 errors. Signed-off-by: theTibi <tkorocz@gmail.com>

fabio-silva · 2026-05-14T09:43:43Z

@copilot please commit @matejkubinec suggestions

Agent-Logs-Url: https://github.com/percona/grafana/sessions/b3b74a3e-bdf6-4fa6-85da-8300fadd96c2 Co-authored-by: fabio-silva <4190654+fabio-silva@users.noreply.github.com>

Copilot · 2026-05-14T09:51:51Z

@copilot please commit @matejkubinec suggestions

Implemented @matejkubinec’s suggestions in 6d526085 (options extracted to Nodes.constants.ts + per-tech icon mapping applied in the dropdown).

Screenshot:

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

download.cypress.io
- Triggering command: /usr/local/bin/node /usr/local/bin/node index.js --exec install (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…down

* PMM-14441 Add field to enable dump encryption & correctly handle downloads Co-authored-by: Copilot <copilot@github.com> * PMM-14441 Fix encryption password field * PMM-14441 Resolve copilot comments * PMM-14441 Use service directly instead of action, conditionally send dump encryption password * PMM-14441 Add validation for pmm dump encryption password * PMM-14441 Fix import & add tooltip * PMM-14441 Remove grafana-icons --------- Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Alex Demidoff <alexander.demidoff@percona.com>

* fix: Stack direction and height * fix: backport missing plugin fix from Grafana * chore: prettier

matejkubinec · 2026-05-20T13:43:04Z

In the last commits I've made some small improvement to the UI layout:

Move "Delete" and "Add Node" button to the right to match Services layout
Move "More options" into the dropdown

Before:

After:

JNKPercona mentioned this pull request Apr 15, 2026

chore: add PMM dependency for one-step installation Percona-Lab/pmm-submodules#4300

Open

1 task

theTibi added 3 commits April 15, 2026 16:25

PMM: Add Install PMM Client dropdown on Inventory Nodes page

dea75fe

Add primary control with MySQL/PostgreSQL/MongoDB menu items that copy a default one-line curl install command. Link to full /pmm-ui/install-client wizard for advanced options. Made-with: Cursor

PMM: Install Client menu creates node install token and copies command

66449f6

Resolve stash onto one_step_install: use management API path for token, optional token in buildQuickInstallCommand, loading state and error message. Made-with: Cursor

PMM: Label Nodes action as Add Node with MySQL/MongoDB/PostgreSQL menu

e431e89

Rename copy to match UX: primary dropdown is Add Node; menu order MySQL, MongoDB, PostgreSQL; clearer success and message keys. Made-with: Cursor

theTibi force-pushed the one_step_install branch from 2553eec to e431e89 Compare April 15, 2026 13:27

JNKPercona mentioned this pull request Apr 28, 2026

pmm and grafana deps for one-step installation Percona-Lab/pmm-submodules#4330

Open

1 task

theTibi and others added 4 commits April 28, 2026 20:18

Merge branch 'main' into one_step_install

743dab9

Merge branch 'main' into one_step_install

e71d808

Merge branch 'main' into one_step_install

0d2a462

mattiasimonato approved these changes May 6, 2026

View reviewed changes

mattiasimonato marked this pull request as ready for review May 6, 2026 13:44

matejkubinec changed the title ~~One step install~~ PMM-14993 One step install May 6, 2026

mattiasimonato self-requested a review May 6, 2026 13:47

fix: apply Prettier to nodes tab utilities

35a21a5

mattiasimonato approved these changes May 6, 2026

View reviewed changes

mattiasimonato requested review from Copilot, fabio-silva and matejkubinec May 11, 2026 12:27

Copilot started reviewing on behalf of mattiasimonato May 11, 2026 12:28 View session

Copilot AI reviewed May 11, 2026

View reviewed changes

Comment thread public/app/percona/inventory/Tabs/NodesInstallCommand.utils.ts

Comment thread public/app/percona/inventory/Tabs/Nodes.tsx

Comment thread public/app/percona/inventory/Tabs/NodesInstallCommand.utils.ts

mattiasimonato and others added 3 commits May 11, 2026 18:06

fix: add unit tests for buildQuickInstallCommand

6781820

matejkubinec reviewed May 14, 2026

View reviewed changes

Comment thread public/app/percona/inventory/Tabs/Nodes.tsx Outdated

Comment thread public/app/percona/inventory/Tabs/Nodes.tsx Outdated

Copilot started work on behalf of fabio-silva May 14, 2026 09:43 View session

Copilot AI and others added 2 commits May 14, 2026 09:50

refactor: extract node install options constants and map icons by tech

6d52608

Agent-Logs-Url: https://github.com/percona/grafana/sessions/b3b74a3e-bdf6-4fa6-85da-8300fadd96c2 Co-authored-by: fabio-silva <4190654+fabio-silva@users.noreply.github.com>

Merge branch 'main' into one_step_install

71f24b7

fabio-silva requested a review from matejkubinec May 14, 2026 09:53

Copilot finished work on behalf of fabio-silva May 14, 2026 09:53

fabio-silva approved these changes May 14, 2026

View reviewed changes

mattiasimonato and others added 3 commits May 14, 2026 12:38

Merge branch 'main' into one_step_install

b54b974

fix(inventory): align quick install icons with Percona branding

3acb5dc

Merge branch 'main' into one_step_install

ccd755a

matejkubinec approved these changes May 14, 2026

View reviewed changes

ademidoff and others added 7 commits May 15, 2026 12:39

Merge branch 'main' into one_step_install

05ed569

Merge branch 'main' into one_step_install

ab40df6

feat: unify design between services nodes, put more options into drop…

8de4294

…down

Fix grafana stack height & back port fix from Grafana (#903)

bf6ddb4

* fix: Stack direction and height * fix: backport missing plugin fix from Grafana * chore: prettier

feat: provide data testid for add node button

a4fa43e

Merge branch 'main'

cab7cd5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PMM-14993 One step install#894

PMM-14993 One step install#894
theTibi wants to merge 24 commits into
mainfrom
one_step_install

theTibi commented Apr 15, 2026 •

edited by matejkubinec

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fabio-silva commented May 14, 2026

Uh oh!

Copilot AI commented May 14, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

matejkubinec commented May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

theTibi commented Apr 15, 2026 • edited by matejkubinec Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fabio-silva commented May 14, 2026

Uh oh!

Copilot AI commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

matejkubinec commented May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

theTibi commented Apr 15, 2026 •

edited by matejkubinec

Loading

Copilot AI commented May 14, 2026 •

edited

Loading