fix: ensure WebSocket notifications are sent before application quits#4381
Open
cjuriartec wants to merge 1 commit intopear-devs:masterfrom
Open
fix: ensure WebSocket notifications are sent before application quits#4381cjuriartec wants to merge 1 commit intopear-devs:masterfrom
cjuriartec wants to merge 1 commit intopear-devs:masterfrom
Conversation
JellyBrick
requested changes
Mar 31, 2026
|
|
||
| export const backend = createBackend<BackendType, APIServerConfig>({ | ||
| async start(ctx) { | ||
| const { app } = await import('electron'); |
Member
There was a problem hiding this comment.
Is there a reason you used await import?
Member
There was a problem hiding this comment.
Maybe they were not aware that vite does tree-shaking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When closing the application (e.g. via Cmd+Q on macOS), the WebSocket clients wouldn't consistently receive a final "isPlaying: false" state because the application was terminating before the network buffers could be flushed.
Solution
before-quitevent listener in the main backend process that triggers this notification.as unknown as WSContext<WebSocket>to prevent TypeScript errors.Testing
Verified with Boring Notch connection. The notification is now consistently received before Pear Desktop fully exits.