Skip to content

chore: remove test_iterative_singular #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpbrodrick89 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

chore: remove test_iterative_singular #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 4 additions & 29 deletions tests/test_singular.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@
from .helpers import (
construct_singular_matrix,
finite_difference_jvp,
make_jac_operator,
make_matrix_operator,
ops,
params,
tol,
Expand Down Expand Up @@ -241,30 +239,7 @@ def test_nonsquare_vec(solver, full_rank, jvp, wide, dtype, getkey):
assert tree_allclose(x, true_x, atol=1e-4, rtol=1e-4)


_iterative_solvers = (
(lx.CG(rtol=tol, atol=tol), lx.positive_semidefinite_tag),
(lx.CG(rtol=tol, atol=tol, max_steps=512), lx.negative_semidefinite_tag),
(lx.GMRES(rtol=tol, atol=tol), ()),
(lx.BiCGStab(rtol=tol, atol=tol), ()),
)


@pytest.mark.parametrize("make_operator", (make_matrix_operator, make_jac_operator))
@pytest.mark.parametrize("solver, tags", _iterative_solvers)
@pytest.mark.parametrize("use_state", (False, True))
@pytest.mark.parametrize("dtype", (jnp.float64, jnp.complex128))
def test_iterative_singular(getkey, solver, tags, use_state, make_operator, dtype):
(matrix,) = construct_singular_matrix(getkey, solver, tags)
operator = make_operator(getkey, matrix, tags)

out_size, _ = matrix.shape
vec = jr.normal(getkey(), (out_size,), dtype=dtype)

if use_state:
state = solver.init(operator, options={})
linear_solve = ft.partial(lx.linear_solve, state=state)
else:
linear_solve = lx.linear_solve

with pytest.raises(Exception):
linear_solve(operator, vec, solver)
# No test for iterative solvers on singular operators: Krylov methods have no rank
# detection and no defined behaviour on rank-deficient systems, so there is nothing to
# assert (their failure reporting is covered by test_bicgstab_breakdown and
# test_gmres_stagnation_or_breakdown above).
Loading