Make MPO great again#230
Merged
Merged
Conversation
murogrande
reviewed
Mar 27, 2026
murogrande
reviewed
Mar 27, 2026
murogrande
reviewed
Mar 27, 2026
murogrande
reviewed
Mar 27, 2026
murogrande
reviewed
Mar 27, 2026
murogrande
reviewed
Mar 27, 2026
Contributor
murogrande
left a comment
There was a problem hiding this comment.
Is it possible to have value as a metric regarding this change? Because, I have the feeling that something internally in the code has changed. I see that all the test pass but internally, what about the bond dimension? it grows faster than before? I think that the bond will increase, won't it?
Contributor
Author
|
@murogrande I dont see at the moment why the bond dim should grow. Actually, the Hamiltonian bond dim stays the same UPD: added a comment to the PR description. XY and S+S- are identical in terms of bond dim and memory and observables |
elmerhej
reviewed
Mar 30, 2026
elmerhej
reviewed
Mar 30, 2026
elmerhej
reviewed
Mar 30, 2026
elmerhej
reviewed
Mar 30, 2026
elmerhej
reviewed
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enforces Hermiticity of MPO tensor nodes for the XY model by reformulating the interaction terms.
What changed
to the equivalent form:
While MPO tensor nodes are not required to be Hermitian in general, the resulting Hamiltonian must be Hermitian. Enforcing Hermiticity at the tensor level provides a practical advantage:
Notes
Comment :
Mauro suggested to compare memory consumption of the original and new MPO. I didn't bother making plots, because results are identical. Setup : quench with amplitude = 1. system size 4x2 rectangular array, initial state
rrrrggggqubit density at the final time
qubit density at the final time