Fix / improve window behaviour: restore pre-fullscreen/pre-scratch window size/position; better manage windows that start fullscreen

tiling.js

@@ -380,6 +380,15 @@ export class Space extends Array {
             this.setSpaceTopbarElementsVisible(true);
         });
 
+        // after layout is complete, remove any residual fullscreenOnLayout
+        this.signals.connect(this, "layout", () => {
+            this.getWindows().forEach(w => {
+                if (w.fullscreenOnLayout) {
+                    delete w.fullscreenOnLayout;
+                }
+            });
+        });
+
         this.signals.connect(interfaceSettings, "changed::color-scheme", this.updateBackground.bind(this));
         this.signals.connect(gsettings, 'changed::default-background', this.updateBackground.bind(this));
         this.signals.connect(gsettings, 'changed::use-default-background', this.updateBackground.bind(this));
@@ -622,6 +631,13 @@ export class Space extends Array {
         let y0 = workArea.y;
         let fixPointAttempCount = 0;
 
+        // apply fullscreen if windows has fullscreenOnLayout property set
+        this.getWindows()
+        .filter(w => w.fullscreenOnLayout)
+        .forEach(w => {
+            w.make_fullscreen();
+        });
+
         for (let i = 0; i < this.length; i++) {
             let column = this[i];
             // Actorless windows are trouble. Layout could conceivable run while a window is dying or being born.
@@ -914,7 +930,7 @@ export class Space extends Array {
      * Returns true iff this space has a currently fullscreened window.
      */
     hasFullScreenWindow() {
-        return this.getWindows().some(el => el.fullscreen);
+        return this.getWindows().some(w => w.fullscreen);
     }
 
     swap(direction, metaWindow) {
@@ -3307,6 +3323,13 @@ export function insertWindow(metaWindow, { existing }) {
             activateWindowAfterRendered(actor, metaWindow);
             return;
         }
+
+        // address inserting windows that are already fullscreen: windows will be inserted
+        // as normal (non-fullscreen) and will be fullscreened on layout.
+        if (metaWindow.fullscreen) {
+            metaWindow.fullscreenOnLayout = true;
+            metaWindow.unmake_fullscreen();
+        }
     }
 
     if (metaWindow.is_on_all_workspaces()) {