fix: validate materialized immutable_inputs paths to survive macOS te…#23458
Open
thiago-carbonera wants to merge 1 commit into
Open
fix: validate materialized immutable_inputs paths to survive macOS te…#23458thiago-carbonera wants to merge 1 commit into
thiago-carbonera wants to merge 1 commit into
Conversation
thiago-carbonera
force-pushed
the
fix/immutable-inputs-revalidation
branch
2 times, most recently
from
eb81417 to
7ae8cba
Compare
…mp reaper (pantsbuild#23411) Signed-off-by: Thiago Riemma Carbonera <thiagoriemma@gmail.com>
thiago-carbonera
force-pushed
the
fix/immutable-inputs-revalidation
branch
from
7ae8cba to
495f847
Compare
Contributor
Author
|
@benjyw Could you review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23411
Problem
On macOS, a long-running
pantsdinstance can outlive the OS periodic temp cleaner (which reaps unaccessed files in$TMPDIRafter ~3 days).ImmutableInputs::path_for_dirwas memoizing paths in memory and returning them without verifying if the underlying directory still existed on disk, causing tools like Docker to fail withexecutable file not found in $PATHbecause their$PATHpointed to a deleted directory.Solution
path_for_dirto checkpath.exists()on the cachedPathBuf.OnceCelland forces the directory to be re-materialized.local_tests.rsto simulate the exact OS reaper behavior.