drop python3.9 specific tests that use the bundled lockfiles#23457
Draft
cburroughs wants to merge 1 commit into
Draft
drop python3.9 specific tests that use the bundled lockfiles#23457cburroughs wants to merge 1 commit into
cburroughs wants to merge 1 commit into
Conversation
cburroughs
commented
Jun 29, 2026
|
|
||
|
|
||
| @skip_unless_python39_present | ||
| @skip_unless_python310_present |
Contributor
Author
There was a problem hiding this comment.
(We should maybe have an "oldest supported Python for bundled tools" shortcut.)
cburroughs
added
the
release-notes:not-required
I think these "does black/mypy support Python syntax circa 2020?" tests have outlived their usefulness and removing them makes it easier to drop support for Python 3.9 (EoL since 2025-10-31). There are still tests that use 3.8 when custom test lockfiles when available, which cover the "Does Pants work with Pythons older than the bundled tool lockfiles?" case.
cburroughs
force-pushed
the
csb/locks-eol-bundled-tests-1
branch
from
f3b1b3d to
ed56c0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think these "does black/mypy support Python syntax circa 2020?" tests have outlived their usefulness and removing them makes it easier to drop support for Python 3.9 (EoL since 2025-10-31).
There are still tests that use 3.8 when custom test lockfiles when available, which cover the "Does Pants work with Pythons older than the bundled tool lockfiles?" case.