Pass the same set of object files when retrying linking for cgo#23447
Open
skirino wants to merge 1 commit into
Open
Pass the same set of object files when retrying linking for cgo#23447skirino wants to merge 1 commit into
skirino wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the latest
mainbranch,pants test src/python/pants/backend/go/util_rules/cgo_test.py:testsfails in my environment:The 3 tests fail with the same linker error:
(found this issue during playing around the tests in #23439)
In
cgo.py, linking of object files are retried with additional linker options:https://github.com/pantsbuild/pants/blob/main/src/python/pants/backend/go/util_rules/cgo.py#L500-L559
For relatively simple case, linking succeeds at the 1st try. In the case of ObjC, C++ and Fortran tests, linking fails (due to lack of the language's stdlib?) and retried.
_main(cgo-generated dummy function) resides in_cgo_main.ofile and is required by the linker, but the object file is not included in the linker flags at the 2nd try.My environment: