Add filepath completion#184
Open
rszyma wants to merge 7 commits into
Open
Conversation
rszyma
force-pushed
the
filepath-completion
branch
2 times, most recently
from
f9c7185 to
97cb525
Compare
rszyma
force-pushed
the
filepath-completion
branch
from
97cb525 to
5183704
Compare
> use of deprecated function `std::env::home_dir`: This function's behavior may be unexpected on Windows. Consider using a crate from crates.io instead.
Contributor
Author
|
This is good enough for review now. From some manual testing I did, it works in every case I could think of:
edit: also tested for absolute paths |
oxalica
added
C-feature
..instead of full token. Every other completion works like this too. For example: ./pa$0th/to/file previously this would only show files starting with `./path/to/file`, not `./pa` like expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #183
This PR adds completion for local file paths.
It works by suggesting only next possible segments in a path, not recursively all files. It's similar to gopls path suggestions of modules.
TODO
./$0not working, because it's being parsed asBinaryOp(BinaryOp(BINARY_OP@0..2))(a division operation?), while I'd expect it to parse as literal, just like./asdf/$0parses asLiteral(Literal(LITERAL@0..7)). This should either be fixed in in parser or though some hack. This also applies to../$0and~/$0.globlib with something native? Maybestd::fs::read_dir? We don't need full glob capability.