Skip to content

Remove deprecated Client wrapper#237

Closed
StantonMatt wants to merge 2 commits into
overtrue:mainfrom
StantonMatt:remove-deprecated-client
Closed

Remove deprecated Client wrapper#237
StantonMatt wants to merge 2 commits into
overtrue:mainfrom
StantonMatt:remove-deprecated-client

Conversation

@StantonMatt

Copy link
Copy Markdown
Contributor

Summary

  • Remove the deprecated Overtrue\PHPLint\Client wrapper.
  • Pass application version context directly from LintCommand into Linter.
  • Cover that the command still exposes short/long application versions in LinterOutput context.

Fixes #235

Verification

  • vendor/bin/phpunit --no-progress --testdox --do-not-cache-result
  • vendor/bin/phpstan analyse --no-progress
  • php bin/phplint src tests --exclude fixtures --no-cache --no-configuration --no-progress
  • git diff --check

Signed-off-by: Matthew Stanton <stantonmatthewj@gmail.com>
Signed-off-by: Matthew Stanton <stantonmatthewj@gmail.com>
@llaville

llaville commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

@StantonMatt Sorry, this time, I won't apply your patch.

Reason, I'm working on version 9.8, and a quick fix was already applied on branch 9.8 : see #235

I won't apply it directly to the main branch (current 9.7.x versions)

@llaville llaville closed this Jun 4, 2026
@StantonMatt

Copy link
Copy Markdown
Contributor Author

Understood, thanks for the context. I'll leave main alone here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9.8 | Remove deprecated Client class

2 participants